Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-30 Thread Alan Bateman
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-30 Thread David Holmes
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/ [v2]

2023-01-30 Thread David Holmes
On Mon, 30 Jan 2023 09:30:36 GMT, Johan Sjölen wrote: >> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory >> share/prims/. Unfortunately the script that does the change isn't perfect, >> and so we >> need to comb through these manually to make sure nothing has gone wr

Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

2023-01-30 Thread Chris Plummer
On Mon, 30 Jan 2023 20:11:06 GMT, Kevin Walls wrote: >> src/jdk.management.agent/share/conf/management.properties line 323: >> >>> 321: java.rmi.dgc.*;\ >>> 322: java.rmi.server.*;\ >>> 323: javax.security.auth.Subject;!* >> >> What does the ! at the end indicate? > > It's "not everything else"

Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

2023-01-30 Thread Serguei Spitsyn
On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls wrote: >> The default setting for the ObjectInputFilter for JMX, introduced in jdk20, >> is too restrictive. >> javax.management.Attribute and AttributeList classes are also needed, and >> Query related classes. >> >> There are a number of Query-re

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-30 Thread Alex Menkov
On Fri, 27 Jan 2023 04:16:05 GMT, Ioi Lam wrote: >>>I'd expect that at least java.util.Date and java.lang.ProcessBuilder have >>>the same verification requirement. >> >> Generally speaking yes - they are both loaded by bootstrap loader and so >> would both have verification disabled by default

Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

2023-01-30 Thread Kevin Walls
On Mon, 30 Jan 2023 19:21:37 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - filter properties update: more classes logged as ALLOWED during wider >> testing >> - Add a Notification test > > s

Re: RFR: 8297638: Memory leak in case of many started-dead threads [v2]

2023-01-30 Thread Egor Ushakov
On Thu, 19 Jan 2023 21:59:22 GMT, Chris Plummer wrote: >> Fix JDI leak when the debuggee creates a lot of threads, while at the same >> the debugger is not sending any commands. The lack of commands being sent >> results in code not being triggered that normally would clear out >> unreachable

Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

2023-01-30 Thread Chris Plummer
On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls wrote: >> The default setting for the ObjectInputFilter for JMX, introduced in jdk20, >> is too restrictive. >> javax.management.Attribute and AttributeList classes are also needed, and >> Query related classes. >> >> There are a number of Query-re

Re: RFR: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

2023-01-30 Thread Alan Bateman
On Mon, 23 Jan 2023 21:02:51 GMT, Chris Plummer wrote: > jdb creates a ThreadStartRequest and ThreadDeathRequest so it can track all > created threads. It creates them with the SUSPEND_ALL policy. This is > unnecessary since jdb always immediately resumes all threads after doing the > thread b

Re: RFR: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

2023-01-30 Thread Chris Plummer
On Mon, 23 Jan 2023 21:02:51 GMT, Chris Plummer wrote: > jdb creates a ThreadStartRequest and ThreadDeathRequest so it can track all > created threads. It creates them with the SUSPEND_ALL policy. This is > unnecessary since jdb always immediately resumes all threads after doing the > thread b

Integrated: 8300810: Get rid of unused JDI removeListener() methods

2023-01-30 Thread Chris Plummer
On Mon, 23 Jan 2023 20:58:20 GMT, Chris Plummer wrote: > Remove removeListener() methods. They are not called. This pull request has now been integrated. Changeset: a128a5d0 Author:Chris Plummer URL: https://git.openjdk.org/jdk/commit/a128a5d07c3b5d710316aab0c02ccaec4872dc22 Stats:

Integrated: 8298907: nsk JDI tests pass if the debuggee failed to launch

2023-01-30 Thread Leonid Mesnik
On Fri, 27 Jan 2023 23:24:43 GMT, Leonid Mesnik wrote: > Updated run() to return exitCode and make testExitCode non-static to don't > use it in run() This pull request has now been integrated. Changeset: a91143cc Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/a91143cc

Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/ [v2]

2023-01-30 Thread Kim Barrett
On Mon, 30 Jan 2023 09:30:36 GMT, Johan Sjölen wrote: >> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory >> share/prims/. Unfortunately the script that does the change isn't perfect, >> and so we >> need to comb through these manually to make sure nothing has gone wr

Integrated: 8267935: Replace BasicHashtable and Hashtable

2023-01-30 Thread Afshin Zafari
On Sat, 28 Jan 2023 18:32:31 GMT, Afshin Zafari wrote: > ### Description > Hashtable class to be replaced with ResourceHashtable class in all source > code. > > ### Patch > The only instance was `#include "hashtable.hpp"` in `jvmtiTagMapTable.cpp` > and removed. > The corresponding files (`ha

Re: RFR: 8267935: Replace BasicHashtable and Hashtable

2023-01-30 Thread Thomas Schatzl
On Sat, 28 Jan 2023 18:32:31 GMT, Afshin Zafari wrote: > ### Description > Hashtable class to be replaced with ResourceHashtable class in all source > code. > > ### Patch > The only instance was `#include "hashtable.hpp"` in `jvmtiTagMapTable.cpp` > and removed. > The corresponding files (`ha

Re: RFR: 8299234: JMX Repository.query performance [v4]

2023-01-30 Thread Daniel Fuchs
On Mon, 23 Jan 2023 20:25:17 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8267935: Replace BasicHashtable and Hashtable

2023-01-30 Thread Robbin Ehn
On Sat, 28 Jan 2023 18:32:31 GMT, Afshin Zafari wrote: > ### Description > Hashtable class to be replaced with ResourceHashtable class in all source > code. > > ### Patch > The only instance was `#include "hashtable.hpp"` in `jvmtiTagMapTable.cpp` > and removed. > The corresponding files (`ha

Re: RFR: 8301279: update for deprecated sprintf for management components

2023-01-30 Thread Xue-Lei Andrew Fan
On Mon, 30 Jan 2023 10:23:02 GMT, Kevin Walls wrote: >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failure, and >> [JDK-8299378](https://bugs.openjdk.org/browse

Re: RFR: 8291555: Implement alternative fast-locking scheme [v7]

2023-01-30 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Thu, 26 Jan 2023 13:45:35 GMT, Robbin Ehn wrote: > > > I always change the flags in code for the reasons David state and I can't > > > forget to add any flags. > > > (Test batch is stilling running, no failures except > > > MonitorInflationTest.java) > > > > > > Ok, right. > > I just re-ra

Re: RFR: 8291555: Implement alternative fast-locking scheme [v5]

2023-01-30 Thread Roman Kennke
On Fri, 27 Jan 2023 20:50:32 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 86 commits: >> >> - Merge branch 'master' into JDK-8291556-v2 >> - Revert UseFastLocking to default to

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Wed, 25 Jan 2023 20:02:35 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert UseFastLocking to default to off > > src/hotspot/share/oops/markWord.hpp line 183: > >> 181: } >> 182

Re: RFR: 8267935: Replace BasicHashtable and Hashtable

2023-01-30 Thread Coleen Phillimore
On Sat, 28 Jan 2023 18:32:31 GMT, Afshin Zafari wrote: > ### Description > Hashtable class to be replaced with ResourceHashtable class in all source > code. > > ### Patch > The only instance was `#include "hashtable.hpp"` in `jvmtiTagMapTable.cpp` > and removed. > The corresponding files (`ha

Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

2023-01-30 Thread Kevin Walls
On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls wrote: >> The default setting for the ObjectInputFilter for JMX, introduced in jdk20, >> is too restrictive. >> javax.management.Attribute and AttributeList classes are also needed, and >> Query related classes. >> >> There are a number of Query-re

Re: RFR: 8291555: Implement alternative fast-locking scheme [v5]

2023-01-30 Thread Roman Kennke
On Fri, 27 Jan 2023 19:33:16 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 86 commits: >> >> - Merge branch 'master' into JDK-8291556-v2 >> - Revert UseFastLocking to default to

Re: RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch [v2]

2023-01-30 Thread Kevin Walls
On Sat, 28 Jan 2023 00:47:47 GMT, Leonid Mesnik wrote: >> Updated run() to return exitCode and make testExitCode non-static to don't >> use it in run() > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > cp updated Looks goo

Re: RFR: 8301279: update for deprecated sprintf for management components

2023-01-30 Thread Kevin Walls
On Fri, 27 Jan 2023 20:32:35 GMT, Xue-Lei Andrew Fan wrote: > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for building failure, and > [JDK-8299378](https://bugs.openjdk.org/browse/

Re: RFR: 8291555: Implement alternative fast-locking scheme [v6]

2023-01-30 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Wed, 25 Jan 2023 17:42:23 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert UseFastLocking to default to off > > src/hotspot/share/runtime/objectMonitor.cpp line 1141: > >> 1139:

Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/

2023-01-30 Thread Johan Sjölen
On Wed, 25 Jan 2023 11:47:05 GMT, Johan Sjölen wrote: > Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory > share/prims/. Unfortunately the script that does the change isn't perfect, > and so we > need to comb through these manually to make sure nothing has gone wrong.

Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/ [v2]

2023-01-30 Thread Johan Sjölen
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory > share/prims/. Unfortunately the script that does the change isn't perfect, > and so we > need to comb through these manually to make sure nothing has gone wrong. I > also review these changes but things slip past my

Re: RFR: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2023-01-30 Thread Kevin Walls
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac