On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
>> is too restrictive.
>> javax.management.Attribute and AttributeList classes are also needed, and
>> Query related classes.
>>
>> There are a number of Query-related classes, so adding javax.management.* is
>> appropriate otherwise the list becomes hard to manage. This is a * and not
>> a ** which would mean all subpackages, so the openmean subpackage stays in
>> the list.
>
> Kevin Walls has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - filter properties update: more classes logged as ALLOWED during wider
> testing
> - Add a Notification test
This fix looks okay to me.
One nit was inlined.
Thanks,
Serguei
test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
line 150:
> 148: String description = "An attribute of this MBean has
> changed";
> 149: MBeanNotificationInfo info = new
> MBeanNotificationInfo(types, name, description);
> 150: return new MBeanNotificationInfo[] {info};
Nit: It can be useful to print that this method was invoked the same as in
other methods.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.org/jdk20/pull/97
