On Wed, 25 Jan 2023 11:47:05 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory > share/prims/. Unfortunately the script that does the change isn't perfect, > and so we > need to comb through these manually to make sure nothing has gone wrong. I > also review these changes but things slip past my eyes sometimes. > > Here are some typical things to look out for: > > 1. No changes but copyright header changed (probably because I reverted some > changes but forgot the copyright). > 2. Macros having their NULL changed to nullptr, these are added to the script > when I find them. They should be NULL. > 3. nullptr in comments and logs. We try to use lower case "null" in these > cases as it reads better. An exception is made when code expressions are in a > comment. > > An example of this: > > ```c++ > // This function returns null > void* ret_null(); > // This function returns true if *x == nullptr > bool is_nullptr(void** x); > > > Note how `nullptr` participates in a code expression here, we really are > talking about the specific value `nullptr`. > > Thanks! Thanks for these review comments, I've fixed your suggestions. I must've accidentally submitted a different branch for tier1 testing, as this doesn't compile. ------------- PR: https://git.openjdk.org/jdk/pull/12188
