On Tue, 29 Nov 2022 02:36:12 GMT, Alex Menkov wrote:
>> The fix combines almost the same tests to 1 test to remove code duplication
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Used multiple test tags
Marked as reviewed
On Mon, 28 Nov 2022 09:51:25 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which only fixes typos in
> src/hotspot and test/hotspot files? These changes were originally done by
> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the
> other PR touch
On Tue, 29 Nov 2022 02:36:12 GMT, Alex Menkov wrote:
>> The fix combines almost the same tests to 1 test to remove code duplication
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Used multiple test tags
Looks good - nice c
On Mon, 28 Nov 2022 09:51:25 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which only fixes typos in
> src/hotspot and test/hotspot files? These changes were originally done by
> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the
> other PR touch
On Tue, 29 Nov 2022 01:12:52 GMT, Leonid Mesnik wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Used multiple test tags
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.jav
> The fix combines almost the same tests to 1 test to remove code duplication
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Used multiple test tags
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11400/files
- ne
On Mon, 28 Nov 2022 11:52:22 GMT, Erik Österlund wrote:
>> There is a stack walk in JvmtiExport::post_exception_throw() that has
>> safepoints in it. This trips up the stack watermark code. This patch adds a
>> RAII object to JvmtiExport::post_exception_throw() that keeps the thread and
>> its
On Mon, 28 Nov 2022 23:28:00 GMT, Alex Menkov wrote:
> The fix combines almost the same tests to 1 test to remove code duplication
test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.java
line 45:
> 43: *
> 44: * @comment Direct access to the metrics.
> 45
> The current non local registry tests require a manual process that runs
> rmiregitrty on a different machine and changes the -Dregistry.host property
> in the source before running the tests on the local machine. This task is
> created to improve this manual process and provide a clearer instr
> The current non local registry tests require a manual process that runs
> rmiregitrty on a different machine and changes the -Dregistry.host property
> in the source before running the tests on the local machine. This task is
> created to improve this manual process and provide a clearer instr
The fix combines almost the same tests to 1 test to remove code duplication
-
Commit messages:
- Combined nsk resetPeakThreadCount tests
Changes: https://git.openjdk.org/jdk/pull/11400/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11400&range=00
Issue: https://bugs.openj
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Mon, 28 Nov 2022 11:35:48 GMT, Afshin Zafari wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 254:
>>
>>> 252: if (obj_tag != current_tag ) {
>>> 253: hashmap->remove(o);
>>> 254: hashmap->add(o, obj_tag);
>>
>> This change is not atomic - is that a problem? The c
On Thu, 24 Nov 2022 00:24:00 GMT, David Holmes wrote:
> This is mainly an expansion of the included platforms by changing "linux and
> macOS" to "Non-Windows". There are a few additional examples, and
> clarification that they are just examples. There are also some minor edits
> and correction
On Mon, 28 Nov 2022 21:48:40 GMT, Ioi Lam wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix formatting
>
> LGTM
Thanks @iklam !
-
PR: https://git.openjdk.org/jdk/pull/11340
On Thu, 24 Nov 2022 00:50:22 GMT, David Holmes wrote:
>> This is mainly an expansion of the included platforms by changing "linux and
>> macOS" to "Non-Windows". There are a few additional examples, and
>> clarification that they are just examples. There are also some minor edits
>> and correc
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Mon, 28 Nov 2022 17:54:51 GMT, Bill Huang wrote:
>> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>> line 167:
>>
>>> 165:
>>> Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName)));
>>> 166: Set hostAddrs =
>>> 167:
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Mon, 28 Nov 2022 13:56:29 GMT, Alan Bateman wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
> line 167:
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Mon, 28 Nov 2022 12:14:59 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo
wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Richard comments
>
> I went through the changes and all looks good to me. Only minor comments.
>
> Th
On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang wrote:
>> The current non local registry tests require a manual process that runs
>> rmiregitrty on a different machine and changes the -Dregistry.host property
>> in the source before running the tests on the local machine. This task is
>> created t
On Mon, 28 Nov 2022 12:14:59 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo
wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Richard comments
>
> I went through the changes and all looks good to me. Only minor comments.
>
> Th
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Fri, 18 Nov 2022 12:30:19 GMT, Erik Österlund wrote:
> There is a stack walk in JvmtiExport::post_exception_throw() that has
> safepoints in it. This trips up the stack watermark code. This patch adds a
> RAII object to JvmtiExport::post_exception_throw() that keeps the thread and
> its sta
> There is a stack walk in JvmtiExport::post_exception_throw() that has
> safepoints in it. This trips up the stack watermark code. This patch adds a
> RAII object to JvmtiExport::post_exception_throw() that keeps the thread and
> its stack fully processed throughout the function.
> Testing: tie
On Mon, 28 Nov 2022 01:23:30 GMT, David Holmes wrote:
>> test of tier1-5 passed.
>
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 95:
>
>> 93://if (obj->fast_no_hash_check()) {
>> 94:// return 0;
>> 95://} else {
>
> What are these comments?
Coleen's suggestion for efficiency
On Mon, 28 Nov 2022 01:20:49 GMT, David Holmes wrote:
>> test of tier1-5 passed.
>
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 77:
>
>> 75:
>> 76: void JvmtiTagMapTable::clear() {
>> 77: struct RemoveAll{
>
> Nit: space before {
>
> Stylistically I'm not sure we define local structs
On Mon, 28 Nov 2022 01:12:18 GMT, David Holmes wrote:
>> test of tier1-5 passed.
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 254:
>
>> 252: if (obj_tag != current_tag ) {
>> 253: hashmap->remove(o);
>> 254: hashmap->add(o, obj_tag);
>
> This change is not atomic - is
On Mon, 28 Nov 2022 09:51:25 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which only fixes typos in
> src/hotspot and test/hotspot files? These changes were originally done by
> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the
> other PR touch
Can I please get a review for this change which only fixes typos in src/hotspot
and test/hotspot files? These changes were originally done by @mernst in PR
https://github.com/openjdk/jdk/pull/10029, but given that the other PR touches
multiple other files and areas, the progress was stalled.
Th
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Thu, 24 Nov 2022 10:59:41 GMT, Martin Doerr wrote:
> Related issue is fixed with
> [JDK-8228649](https://bugs.openjdk.org/browse/JDK-8228649)
> Test has passed.
This pull request has now been integrated.
Changeset: 012dafee
Author:Martin Doerr
URL:
https://git.openjdk.org/jdk/co
On Thu, 24 Nov 2022 10:59:41 GMT, Martin Doerr wrote:
> Related issue is fixed with
> [JDK-8228649](https://bugs.openjdk.org/browse/JDK-8228649)
> Test has passed.
Thanks for the review!
-
PR: https://git.openjdk.org/jdk/pull/11351
On Sun, 27 Nov 2022 17:49:57 GMT, Michael Ernst wrote:
> Could someone who knows the undocumented ins and outs of creating JDK pull
> requests could split this pull request up into multiple PRs? Then it can be
> merged, rather than wasting all the effort that went into it.
I've raised https://
40 matches
Mail list logo
