On Mon, 28 Nov 2022 11:52:22 GMT, Erik Österlund <eosterl...@openjdk.org> wrote:
>> There is a stack walk in JvmtiExport::post_exception_throw() that has >> safepoints in it. This trips up the stack watermark code. This patch adds a >> RAII object to JvmtiExport::post_exception_throw() that keeps the thread and >> its stack fully processed throughout the function. >> Testing: tier1-7 of ZGC tests on linux x86_64 debug and manual testing of >> the test that failed. > > Erik Österlund has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment Thanks for the added comment. I can approve this as-is but I think we have a significant problem here as it remains completely unclear when `KeepStackGCProcessedMark` is needed or how its omission would be detected. This seems extremely fragile. ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/11238
