On Mon, 28 Nov 2022 09:51:25 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

> Can I please get a review for this change which only fixes typos in 
> src/hotspot and test/hotspot files? These changes were originally done by 
> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the 
> other PR touches multiple other files and areas, the progress was stalled.
> 
> This PR introduces only hotspot related typo fixes that Michael had proposed 
> in the other PR plus also includes a review suggestion (in one of these 
> files) that was made by Alexey in the other PR.

Looks good and trivial. One further issue spotted around one of the fixes but 
feel free ignore.

Thanks for taking care of this @jaikiran !

test/hotspot/jtreg/vmTestbase/nsk/share/locks/DeadlockMaker.java line 31:

> 29: /*
> 30:  * Class used to create deadlocked threads. It is possible to create 2 or 
> more deadlocked thread, also
> 31:  * it is possible to specify resource of which type should lock each 
> deadlocked thread

Even with the corrections this comment still makes little sense, but lets not 
get bogged down trying to improve these old tests. If you feel like it 
s/thread,/threads,/ and add a full-stop at the end of the comment.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11386

Reply via email to