On Tue, 30 Aug 2022 20:11:51 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/protectionDomainCache.hpp line 35:
>>
>>> 33: // The amount of different protection domains used is typically
>>> magnitudes smaller
>>> 34: // than the number of system dictionary entries (loaded classes)
On Mon, 29 Aug 2022 12:11:03 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/protectionDomainCache.cpp line 168:
>>
>>> 166: }
>>> 167:
>>> 168: void ProtectionDomainCacheTable::print_on(outputStream* st) {
>>
>> It is a little disconcerting that `print_on` can no longer be a `con
On Tue, 30 Aug 2022 18:13:21 GMT, Ioi Lam wrote:
>> compute_hash() is always called on a live WeakHandle so will never return
>> null.
>
> I think you should add an assert that the `protection_domain.resolve()` never
> returns null, with a comment explaining why.
I agree. In general if code is
There is a workaround we can do for
[JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217) for the use case
where a step over or step out is being done. This workaround can't be made to
also work for the step into case. From
[JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217)
"There
On Thu, 25 Aug 2022 21:16:22 GMT, Alex Menkov wrote:
> The problem is RedefineClasses does not update cached_class_bytes, so
> subsequent RetransformClasses gets obsolete class bytes (this are testcases
> 3-6 from the new test)
>
> cached_class_bytes are set when an agent instruments the class
The root cause of this CR is that we are trying to access the java heap during
the middle of a GC. This particular test is prone to that happening since it
runs jstack 4 times on the debuggee as it starts up (the debuggee is jshell, so
it does a lot of initialization on startup).
SA needs to de
On Mon, 29 Aug 2022 20:13:46 GMT, Chris Plummer wrote:
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cach
The clhsdb 'pmap' command prints the start addresses and the sizes of the
various load modules. It would be more intuitive to have the end address
printed as the VM.dynlibs jcmd does.
Before:
0x7f8839c38000 5920K /usr/lib64/libc-2.17.so
0x7f883a006000 4072K /usr/lib64/libdl-2.17.so
0x0
On Mon, 29 Aug 2022 20:13:46 GMT, Chris Plummer wrote:
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cach
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cache. They use 4k pages and there are 4k of them.
>
> I thi
> This task convert 3 shell tests below to java version.
> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh
> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
> test/sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh
Bill Huang has updated the pull request incre
> This task converts 2 shell tests to java version.
> test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh
> test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 29 Aug 2022 23:25:11 GMT, Bill Huang wrote:
>> This task converts 2 shell tests to java version.
>> test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh
>> test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
>
> Bill Huang has updated the pull request incrementa
On Tue, 30 Aug 2022 18:17:28 GMT, Bill Huang wrote:
>> This task convert 3 shell tests below to java version.
>> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslNoKeyS
On Mon, 29 Aug 2022 20:13:46 GMT, Chris Plummer wrote:
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cach
On Tue, 30 Aug 2022 18:20:26 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> David's comments
>
> src/hotspot/share/classfile/protectionDomainCache.cpp line 162:
>
>> 160: // Purge any deleted
On Tue, 30 Aug 2022 19:31:00 GMT, Coleen Phillimore wrote:
>> Please review this simple conversion for the ProtectionDomainCacheTable from
>> Old Hashtable to ResourceHashtable. There are specific tests for this table
>> in test/hotspot/jtreg/runtime/Dictionary and
>> serviceability/dcmd/vm/D
> Please review this simple conversion for the ProtectionDomainCacheTable from
> Old Hashtable to ResourceHashtable. There are specific tests for this table
> in test/hotspot/jtreg/runtime/Dictionary and
> serviceability/dcmd/vm/DictionaryStatsTest.java.
> Also tested with tier1-7.
Coleen Phil
On Mon, 29 Aug 2022 12:24:33 GMT, Coleen Phillimore wrote:
>> Please review this simple conversion for the ProtectionDomainCacheTable from
>> Old Hashtable to ResourceHashtable. There are specific tests for this table
>> in test/hotspot/jtreg/runtime/Dictionary and
>> serviceability/dcmd/vm/D
> Please review this simple conversion for the ProtectionDomainCacheTable from
> Old Hashtable to ResourceHashtable. There are specific tests for this table
> in test/hotspot/jtreg/runtime/Dictionary and
> serviceability/dcmd/vm/DictionaryStatsTest.java.
> Also tested with tier1-7.
Coleen Phil
On Fri, 26 Aug 2022 20:13:28 GMT, Serguei Spitsyn wrote:
> If JVM TI GetLocalXXX/SetLocalXXX is called from a virtual thread with the
> thread parameter set to NULL (meaning current thread) then it should get/set
> the value of the locals in the virtual thread frames. Instead, it reads the
> c
> This task convert 3 shell tests below to java version.
> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh
> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
> test/sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh
Bill Huang has updated the pull request incre
On Mon, 29 Aug 2022 12:10:48 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/protectionDomainCache.cpp line 43:
>>
>>> 41:
>>> 42: unsigned int ProtectionDomainCacheTable::compute_hash(const WeakHandle&
>>> protection_domain) {
>>> 43: return (unsigned int)(protection_domain.res
On Fri, 26 Aug 2022 21:33:13 GMT, Serguei Spitsyn wrote:
>> If JVM TI GetLocalXXX/SetLocalXXX is called from a virtual thread with the
>> thread parameter set to NULL (meaning current thread) then it should get/set
>> the value of the locals in the virtual thread frames. Instead, it reads the
On Mon, 29 Aug 2022 20:13:46 GMT, Chris Plummer wrote:
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cach
On Mon, 29 Aug 2022 18:54:58 GMT, Chris Plummer wrote:
> DebuggerBase.writeBytes() is not needed. It is only called by a number of
> other "write" methods, such as writeJBoolean(), but these methods are never
> called, so they can be removed along with writeBytes(). Lastly, writeBytes()
> call
On Mon, 29 Aug 2022 18:54:58 GMT, Chris Plummer wrote:
> DebuggerBase.writeBytes() is not needed. It is only called by a number of
> other "write" methods, such as writeJBoolean(), but these methods are never
> called, so they can be removed along with writeBytes(). Lastly, writeBytes()
> call
On Fri, 26 Aug 2022 21:33:13 GMT, Serguei Spitsyn wrote:
>> If JVM TI GetLocalXXX/SetLocalXXX is called from a virtual thread with the
>> thread parameter set to NULL (meaning current thread) then it should get/set
>> the value of the locals in the virtual thread frames. Instead, it reads the
On Mon, 29 Aug 2022 20:13:46 GMT, Chris Plummer wrote:
> The page caching support in SA is woefully dated. I think it has stayed the
> same for over 20 years when it was originally done for solarix-x86. This code
> has been replicated for every port. Currently all ports only have a 16mb
> cach
On Mon, 29 Aug 2022 18:54:58 GMT, Chris Plummer wrote:
> DebuggerBase.writeBytes() is not needed. It is only called by a number of
> other "write" methods, such as writeJBoolean(), but these methods are never
> called, so they can be removed along with writeBytes(). Lastly, writeBytes()
> call
30 matches
Mail list logo
