On Wed, 20 Jul 2022 18:30:43 GMT, Zhengyu Gu wrote:
> > get_objects_with_tags
>
> @sspitsyn Good catch!
>
> I believe it should be synchronized if `JvmtiEnv::GetObjectsWithTags()` call
> can overlap disable/enable `ObjectFree` event.
>
> But it raises a question: why it needs `remove_and_post
On Tue, 19 Jul 2022 15:47:01 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that moves `HeapRegion::_compaction_top`
> into the `G1FullCollector` class; my reasoning is that these values are
> transient temporary values only ever useful for the full collection
>
On Thu, 21 Jul 2022 01:03:46 GMT, Daniel D. Daugherty
wrote:
>> The version will be 20-ea and the copyright year 2023 (for March 2023
>> release date).
>>
>> Thanks.
>
> Thumbs up. This is a trivial change.
Thanks @dcubed-ojdk !
-
PR: https://git.openjdk.org/jdk/pull/9581
On Thu, 21 Jul 2022 04:11:05 GMT, Chris Plummer wrote:
> > The following RN is related to this question:
> > https://bugs.openjdk.org/browse/JDK-8256558
> > It explicitly says: `SetNotificationMode can be used to explicitly flush
> > ObjectFree events, if needed.`
>
> That wasn't quite what I w
On Wed, 20 Jul 2022 22:21:52 GMT, Chris Plummer wrote:
> Unless this test is run as root, it needs sudo privileges. If it gets them,
> the test runs fine, but leaves around files with root ownership so jtreg
> cannot delete them, and you see errors when "make clean" tries to delete
> them. It'
On Thu, 21 Jul 2022 03:51:32 GMT, Serguei Spitsyn wrote:
> The following RN is related to this question:
> https://bugs.openjdk.org/browse/JDK-8256558
> It explicitly says: `SetNotificationMode can be used to explicitly flush
> ObjectFree events, if needed.`
That wasn't quite what I was getting
On Wed, 13 Jul 2022 18:46:07 GMT, Chris Plummer wrote:
> `Actually I'm going to amend my previous comment about concerns with
> synchronization of the test. I think once the SetEventNotificationMode() call
> returns (after passing JVMTI_DISABLE), the caller should be guaranteed that
> any call
On Wed, 20 Jul 2022 22:21:52 GMT, Chris Plummer wrote:
> Unless this test is run as root, it needs sudo privileges. If it gets them,
> the test runs fine, but leaves around files with root ownership so jtreg
> cannot delete them, and you see errors when "make clean" tries to delete
> them. It'
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote:
> The version will be 20-ea and the copyright year 2023 (for March 2023 release
> date).
>
> Thanks.
Thumbs up. This is a trivial change.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9581
The version will be 20-ea and the copyright year 2023 (for March 2023 release
date).
Thanks.
-
Commit messages:
- 8290489: Initial nroff manpage generation for JDK 20
Changes: https://git.openjdk.org/jdk/pull/9581/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9581&range=
On Tue, 19 Jul 2022 06:30:09 GMT, KIRIYAMA Takuya wrote:
> Failed tests call java.lang.ProcessBuilder in direct, so not used command
> options specified when jtreg command run.
> To run non-localized tests, the locale options should be added in
> ProcessBuilder.
>
> Could you review this fix,
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty
wrote:
> Merge jdk19 -> jdk20.
This pull request has now been integrated.
Changeset: 9c19d89c
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c
Stats: 504 lines in 28
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty
wrote:
> Merge jdk19 -> jdk20.
Mach5 Tier1 passed.
-
PR: https://git.openjdk.org/jdk/pull/9578
Merge jdk19 -> jdk20.
-
Commit messages:
- Merge
- 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update
- 8278274: Update nroff pages in JDK 19 before RC
- 8287916: Address the inconsistency between the constant array and pool size
- 8285407: Improve Xalan
Unless this test is run as root, it needs sudo privileges. If it gets them, the
test runs fine, but leaves around files with root ownership so jtreg cannot
delete them, and you see errors when "make clean" tries to delete them. It's
best that we just don't run the test on OSX if sudo privileges.
On Mon, 18 Jul 2022 23:13:14 GMT, Alex Menkov wrote:
> The test verifies that JDI threads are daemon threads.
> But enumerating threads at breakpoint it performs sanity check that all
> threads returned by ThreadGroup.enumerate hasn't terminated.
> But this is wrong assumption, as the test enum
On Tue, 19 Jul 2022 06:30:09 GMT, KIRIYAMA Takuya wrote:
> Failed tests call java.lang.ProcessBuilder in direct, so not used command
> options specified when jtreg command run.
> To run non-localized tests, the locale options should be added in
> ProcessBuilder.
>
> Could you review this fix,
On Wed, 20 Jul 2022 16:53:39 GMT, Serguei Spitsyn wrote:
> get_objects_with_tags
@sspitsyn Good catch!
I believe it should be synchronized if `JvmtiEnv::GetObjectsWithTags()` call
can overlap disable/enable `ObjectFree` event.
But it raises a question: why it needs `remove_and_post_dead_objec
On Wed, 20 Jul 2022 16:57:21 GMT, Chris Plummer wrote:
> > I see my comment as pending but have no idea why it was not posted.
>
> Your comment is pending because you clicked on "Start a review" instead of
> "Add single comment", and then never finished the review by clicking on
> "Review chan
On Wed, 20 Jul 2022 16:53:39 GMT, Serguei Spitsyn wrote:
> I see my comment as pending but have no idea why it was not posted.
Your comment is pending because you clicked on "Start a review" instead of "Add
single comment", and then never finished the review by clicking on "Review
changes".
-
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
On Mon, 18 Jul 2022 18:59:50 GMT, Zhengyu Gu wrote:
>> @sspitsyn and @coleenp
>>
>> Could you please review? Thanks!
>
>> @zhengyu123 Yes, I'm looking at it.
>
> Thanks, @sspitsyn
@zhengyu123 I've posted my comment but I'm not sure you see it.
-
PR: https://git.openjdk.org/jdk/
On Wed, 20 Jul 2022 06:43:33 GMT, KIRIYAMA Takuya wrote:
>> This looks good.
>> Thanks,
>> Serguei
>
> @sspitsyn
> Thank you for your review. Coud you integrate this fix, please?
@tkiriyama Normally, two reviews are required in Serviceability area.
-
PR: https://git.openjdk.org/jd
24 matches
Mail list logo
