On Tue, 19 Jul 2022 06:30:09 GMT, KIRIYAMA Takuya <d...@openjdk.org> wrote:

> Failed tests call java.lang.ProcessBuilder in direct, so not used command 
> options specified when jtreg command run. 
> To run non-localized tests, the locale options should be added in 
> ProcessBuilder.
> 
> Could you review this fix, please?

It's unclear to me when/why this is needed. For example, I see we are doing 
something similar in list003 and repeat001, but these are both recently added 
tests. None of the other jdb tests are doing this, and I'm not sure what 
inspired the author of these 2 tests to add the locale support. Why is it that 
some jdb tests (and many non-jdb tests) require the -J-Duser.language=en 
-J-Duser.country=US and some don't? I'm just trying to better understand the 
problem.

Also, can you include more log output in the CR if it would be useful in 
clarifying what is going wrong when running the test. Is there any useful 
output other than the exception, which isn't very informative.

-------------

PR: https://git.openjdk.org/jdk/pull/9549

Reply via email to