Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v10]

2022-07-02 Thread Serguei Spitsyn
On Sat, 2 Jul 2022 21:19:55 GMT, Chris Plummer wrote: >> This fixes a bug in the debug agent when there is a request to suspend a >> virtual thread that has already terminated. The issue was that unless the >> debug agent was currently under a "suspend all", it would not properly put >> the vi

Re: RFR: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp [v4]

2022-07-02 Thread kristylee88
On Sat, 2 Jul 2022 04:26:48 GMT, Ioi Lam wrote: >> There are only two implementations of these classes (one for windows, and >> one for posix): >> >> - PlatformEvent >> - PlatformParker >> - PlatformMutex >> - PlatformMonitor >> - ThreadCrashProtection >> >> Before this PR, these classes are d

Re: RFR: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp [v4]

2022-07-02 Thread kristylee88
On Sat, 2 Jul 2022 04:26:48 GMT, Ioi Lam wrote: >> There are only two implementations of these classes (one for windows, and >> one for posix): >> >> - PlatformEvent >> - PlatformParker >> - PlatformMutex >> - PlatformMonitor >> - ThreadCrashProtection >> >> Before this PR, these classes are d

Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v10]

2022-07-02 Thread Chris Plummer
> This fixes a bug in the debug agent when there is a request to suspend a > virtual thread that has already terminated. The issue was that unless the > debug agent was currently under a "suspend all", it would not properly put > the virtual thread on the `otherThreads` list, and instead added i

[jdk19] Integrated: 8289619: JVMTI SelfSuspendDisablerTest.java failed with RuntimeException: Test FAILED: Unexpected thread state

2022-07-02 Thread Serguei Spitsyn
On Sat, 2 Jul 2022 19:16:19 GMT, Serguei Spitsyn wrote: > This regression was recently introduced with my update of this test. > One of the newly added checks is not stable/correct: > > > 71 public static void main(String argv[]) throws Exception { > 72 Thread t1 = Thread.ofPlatfo

Re: [jdk19] RFR: 8289619: JVMTI SelfSuspendDisablerTest.java failed with RuntimeException: Test FAILED: Unexpected thread state

2022-07-02 Thread Serguei Spitsyn
On Sat, 2 Jul 2022 19:16:19 GMT, Serguei Spitsyn wrote: > This regression was recently introduced with my update of this test. > One of the newly added checks is not stable/correct: > > > 71 public static void main(String argv[]) throws Exception { > 72 Thread t1 = Thread.ofPlatfo

Re: [jdk19] RFR: 8289619: JVMTI SelfSuspendDisablerTest.java failed with RuntimeException: Test FAILED: Unexpected thread state

2022-07-02 Thread Chris Plummer
On Sat, 2 Jul 2022 19:16:19 GMT, Serguei Spitsyn wrote: > This regression was recently introduced with my update of this test. > One of the newly added checks is not stable/correct: > > > 71 public static void main(String argv[]) throws Exception { > 72 Thread t1 = Thread.ofPlatfo

Re: [jdk19] RFR: 8289619: JVMTI SelfSuspendDisablerTest.java failed with RuntimeException: Test FAILED: Unexpected thread state

2022-07-02 Thread Alan Bateman
On Sat, 2 Jul 2022 19:16:19 GMT, Serguei Spitsyn wrote: > This regression was recently introduced with my update of this test. > One of the newly added checks is not stable/correct: > > > 71 public static void main(String argv[]) throws Exception { > 72 Thread t1 = Thread.ofPlatfo

[jdk19] RFR: 8289619: JVMTI SelfSuspendDisablerTest.java failed with RuntimeException: Test FAILED: Unexpected thread state

2022-07-02 Thread Serguei Spitsyn
This regression was recently introduced with my update of this test. One of the newly added checks is not stable/correct: 71 public static void main(String argv[]) throws Exception { 72 Thread t1 = Thread.ofPlatform().factory().newThread(() -> { 73 testJvmtiThreadState(

Re: RFR: Merge jdk19 [v2]

2022-07-02 Thread kristylee88
On Sat, 2 Jul 2022 18:13:28 GMT, Jesper Wilhelmsson wrote: >> Forwardport JDK 19 -> JDK 20 > > Jesper Wilhelmsson has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 199 commits: > > - Merge remote-tracking branch 'jdk19/master' into

Integrated: Merge jdk19

2022-07-02 Thread Jesper Wilhelmsson
On Sat, 2 Jul 2022 11:03:38 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 70f56933 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/70f5693356277c0685668219a79819707d099d9f Stats: 382 lines i

Re: RFR: Merge jdk19 [v2]

2022-07-02 Thread Jesper Wilhelmsson
> Forwardport JDK 19 -> JDK 20 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 199 commits: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8289603: Code change for JDK-8170762 breaks all build

Integrated: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp

2022-07-02 Thread Ioi Lam
On Tue, 28 Jun 2022 06:16:21 GMT, Ioi Lam wrote: > There are only two implementations of these classes (one for windows, and one > for posix): > > - PlatformEvent > - PlatformParker > - PlatformMutex > - PlatformMonitor > - ThreadCrashProtection > > Before this PR, these classes are declared i

Re: RFR: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp [v2]

2022-07-02 Thread Ioi Lam
On Tue, 28 Jun 2022 19:39:29 GMT, Coleen Phillimore wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed comments > > I very much like this incremental approach to reducing our over-inclusion. Thanks @coleenp @calvinc

RFR: Merge jdk19

2022-07-02 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8245268: -Xcomp is missing from java launcher documentation - 8288703: GetThreadState returns 0 for virtual thread that has terminated - 8288854: getLocalGraphicsEnviro

Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v9]

2022-07-02 Thread Serguei Spitsyn
On Sat, 2 Jul 2022 06:30:13 GMT, Chris Plummer wrote: >> This fixes a bug in the debug agent when there is a request to suspend a >> virtual thread that has already terminated. The issue was that unless the >> debug agent was currently under a "suspend all", it would not properly put >> the vi

Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v9]

2022-07-02 Thread Alan Bateman
On Sat, 2 Jul 2022 06:30:13 GMT, Chris Plummer wrote: >> This fixes a bug in the debug agent when there is a request to suspend a >> virtual thread that has already terminated. The issue was that unless the >> debug agent was currently under a "suspend all", it would not properly put >> the vi

Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v9]

2022-07-02 Thread Serguei Spitsyn
On Sat, 2 Jul 2022 06:30:13 GMT, Chris Plummer wrote: >> This fixes a bug in the debug agent when there is a request to suspend a >> virtual thread that has already terminated. The issue was that unless the >> debug agent was currently under a "suspend all", it would not properly put >> the vi