On Fri, 17 Jun 2022 16:05:38 GMT, Ryan Ernst wrote:
> Applied required casts in jdk.crypto.ec for the upcoming warning.
> Verified by cherry-picking @asotona's patch.
Looks reasonable to me - but it would be good to have someone from
security-dev take a look.
-
PR: https://git.op
On Fri, 17 Jun 2022 16:09:41 GMT, Ryan Ernst wrote:
> Applied required casts in java.security.jgss for the upcoming warning.
> Verified by cherry-picking @asotona's patch.
Looks reasonable to me - but it we be good to have someone from security-dev
take a look.
-
PR: https://git.o
On Thu, 30 Jun 2022 20:36:35 GMT, Roger Riggs wrote:
>> I'm not sure if all unused object will be collected in one GC call always.
>> The gc() specification says "When control returns from the method call, the
>> Java Virtual Machine has made a best effort to reclaim space from all unused
>>
On Fri, 1 Jul 2022 08:26:30 GMT, Xue-Lei Andrew Fan wrote:
>> Maybe not for this PR - but it could be useful to have a version of ForceGC
>> that takes as parameter a `ReferenceQueue` and a `Reference`. That
>> would be more efficient than creating a new object and waiting for a
>> different c
On Fri, 1 Jul 2022 08:06:10 GMT, Сергей Цыпанов wrote:
> In case we read all bytes from an InputStream we don't need wrapping with
> BufferedInputStream as the bytes are not written into internal buffer. With
> removal of redundant buffer we save 8 kB of allocated memory.
I believe that in tha
On Fri, 1 Jul 2022 14:26:24 GMT, Roger Riggs wrote:
>> Thanks @XueleiFan, that's fine by me!
>
> When using Reference/ReferenceQueue there is no Cleaner, only normal
> reference processing (via GC).
I have tests that use Reference/ReferenceQueue to check that an object that
uses a Cleaner has
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Tue, 27 Sep 2022 23:12:43 GMT, Michael Ernst wrote:
> Feel free to break up the pull request if that is what is needed to free it
> from red tape.
Only you can do that @mernst
-
PR: https://git.openjdk.org/jdk/pull/10029
On Wed, 28 Sep 2022 14:45:54 GMT, Michael Ernst wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Reinstate typos in Apache code that is copied into the JDK
>> - Merge ../jdk-openjdk in
On Mon, 3 Oct 2022 14:35:46 GMT, Daniel Jeliński wrote:
> This PR reduces the execution time of ProxyAuthTest.
>
> Before this change the test always required at least 3 minutes to complete
> (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`).
> After this change the te
On Tue, 4 Oct 2022 07:04:42 GMT, Daniel Jeliński wrote:
>> This PR reduces the execution time of ProxyAuthTest.
>>
>> Before this change the test always required at least 3 minutes to complete
>> (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`).
>> After this change t
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
Changes to java.net and javax.managemen
On Wed, 5 Oct 2022 05:43:32 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have the code clean up reviewed?
>
> There is a lot of computation in AESCrypt class load, which could be avoid by
> using the computation result directly. The computation takes 6.971875
> milliseconds in a MacOS M1 l
On Wed, 5 Oct 2022 18:03:09 GMT, Xue-Lei Andrew Fan wrote:
> But please let me know, if you have a strong preference to have it, I will
> try to integrate the table generation code.
Your explanation sounds reasonable to me. I will leave it to security-libs
reviewers and maintainers to make the
On Wed, 5 Oct 2022 15:23:43 GMT, Aleksei Efimov wrote:
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular contr
On Sun, 9 Oct 2022 11:52:18 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granular
On Mon, 10 Oct 2022 12:07:38 GMT, Aleksei Efimov wrote:
>> src/java.naming/share/classes/com/sun/naming/internal/ObjectFactoriesFilter.java
>> line 99:
>>
>>> 97: return globalResult == Status.ALLOWED;
>>> 98: }
>>> 99:
>>
>> If I'm not mistaken there's no point in checki
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
On Fri, 14 Oct 2022 16:19:41 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
On Mon, 17 Oct 2022 15:32:55 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
Deprecate URL constructors. Developers are encouraged to use `java.net.URI` to
parse or construct any URL.
The `java.net.URL` class does not itself encode or decode any URL components
according to the escaping mechanism defined in RFC2396. It is the
responsibility of the caller to encode any fi
On Wed, 26 Oct 2022 17:09:20 GMT, Xue-Lei Andrew Fan wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism
On Wed, 26 Oct 2022 17:39:56 GMT, Xue-Lei Andrew Fan wrote:
>> `URLStreamHandler` really belongs to `java.net.URL`, and is an
>> implementation detail of the infrastructure/SPI that makes it possible to
>> eventually call `URL::openConnection`. I do not think it would be
>> appropriate to have
On Thu, 27 Oct 2022 09:17:29 GMT, Michael McMahon wrote:
>> Having unnamed local variables[^1] would probably be best for this.
>>
>> [^1]: https://openjdk.org/jeps/8294349
>
> How about `_unused` or `_unused1`, `_unused2` then in the meantime?
I'd be happy to make the change. Let's wait to see
On 27/10/2022 07:26, Alan Bateman wrote:
We have a strict URI 3986 implementation, which we use to create all
URL instances from.
Note also that though this change proposes to deprecate these
constructors in order to provide a stronger warning against their
potential misuse, it does not depreca
On Thu, 27 Oct 2022 17:20:04 GMT, Joe Wang wrote:
> Hi Daniel, if it's not a major improvement, we'd like to keep the java.xml
> module at the JDK 8 code level. Can we remove the 'var' usage in a few
> java.xml classes?
No problem - I will make this change when we have settled on a name for th
On Thu, 27 Oct 2022 17:50:37 GMT, Andrey Turbanov wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism de
Some related
> issues will be logged to revisit the calling code.
>
> The CSR can be reviewed here: https://bugs.openjdk.org/browse/JDK-8295949
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated change
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 31 Oct 2022 22:00:01 GMT, Phil Race wrote:
> Deprecate URL constructors. Developers are encouraged to use java.net.URI to
> parse or construct any URL. ... To construct a URL, using URI::toURL should
> be preferred.
>
> You have jumped through some refactoring hoops to be able to apply
On Sat, 29 Oct 2022 14:14:22 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Sat, 29 Oct 2022 14:16:24 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Sat, 29 Oct 2022 14:17:12 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Sat, 29 Oct 2022 14:24:09 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 1 Nov 2022 14:10:01 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URL.java line 133:
>>
>>> 131: * specified. The optional fragment is not inherited.
>>> 132: *
>>> 133: * Constructing instances of
>>> {@code URL}
Some related
> issues will be logged to revisit the calling code.
>
> The CSR can be reviewed here: https://bugs.openjdk.org/browse/JDK-8295949
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated chang
On Tue, 1 Nov 2022 14:47:49 GMT, Alan Bateman wrote:
>> Actually... Maybe I could move up the paragraph that says that URL
>> constructors are deprecated up here, just after the title? Would
>> that be better?
>
> Try it, it might be better. I think the main thing is that link brings the
Some related
> issues will be logged to revisit the calling code.
>
> The CSR can be reviewed here: https://bugs.openjdk.org/browse/JDK-8295949
Daniel Fuchs has updated the pull request incrementally with three additional
commits since the last revision:
- Update src/java.base/share/classe
On Thu, 3 Nov 2022 10:56:28 GMT, Michael McMahon wrote:
>> Daniel Fuchs has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/URL.java
>>
>>Co-
On Thu, 3 Nov 2022 07:42:44 GMT, ExE Boss wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six addi
Some related
> issues will be logged to revisit the calling code.
>
> The CSR can be reviewed here: https://bugs.openjdk.org/browse/JDK-8295949
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated chan
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping me
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 21:56:26 GMT, Jonathan Gibbons wrote:
> On the same text but linking to different RFCs: that's tantamount to a bug
> somewhere. The spec for `@spec` dictates that the URLs and titles should be
> in 1-1 correspondence, and this is supposed to be enforced in the docket. In
>
On Fri, 11 Nov 2022 11:45:43 GMT, Lance Andersen wrote:
> It would probably be easier for the reviewers and for you if the PR could be
> broken out by areas into separate PRs
Leaving out the non-public and non-exported classes would also reduce the PR
size.
-
PR: https://git.open
On Mon, 21 Nov 2022 17:54:15 GMT, Jonathan Gibbons wrote:
>> Please review an update for the troff man pages, following the recent update
>> to upgrade to use pandoc 2.19.2
>> (See https://bugs.openjdk.org/browse/JDK-8297165)
>>
>> In conjunction with this, one javadoc test also needs to be upd
On Tue, 22 Nov 2022 22:04:57 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Mon, 28 Nov 2022 10:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes the typos in the test
>> packages? @mernst submitted this as a separate PR
>> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
>> files that other PR touches
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Thu, 1 Dec 2022 19:36:16 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> lis
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
src/java.base/share/classes/sun/launcher/re
On Fri, 16 Dec 2022 09:20:07 GMT, Daniel Fuchs wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert old translation. Fix lang codes
>
> src/java.base/share/classes/sun/launcher/re
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote:
>> With generalized see and link tags that can refer to anchors (JDK-8200337),
>> the see and link tags in core libraries should be updated to use this
>> feature when possible. This PR covers such updates for java.base.
>
> Joe Darcy has updat
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote:
>> With generalized see and link tags that can refer to anchors (JDK-8200337),
>> the see and link tags in core libraries should be updated to use this
>> feature when possible. This PR covers such updates for java.base.
>
> Joe Darcy has updat
On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung wrote:
>> A trivial fix. Convert the use of anonymous inner classes in a few
>> Permission classes to lambdas to work around JDK-8076596, which has been
>> resolved.
>
> Mandy Chung has updated the pull request incrementally with one additional
>
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
@wangwe
On Thu, 9 Mar 2023 16:02:33 GMT, Alexey Bakhtin wrote:
>> This patch fixes a possible native memory leak in case of a custom native
>> GSS provider.
>> The actual leak was reported in production.
>>
>> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
>> are passed
>
On Mon, 13 Mar 2023 17:33:12 GMT, Alexey Bakhtin wrote:
>> This patch fixes a possible native memory leak in case of a custom native
>> GSS provider.
>> The actual leak was reported in production.
>>
>> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
>> are passed
>
On Tue, 14 Mar 2023 15:09:04 GMT, Alexey Bakhtin wrote:
>> This patch fixes a possible native memory leak in case of a custom native
>> GSS provider.
>> The actual leak was reported in production.
>>
>> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
>> are passed
>
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Mon, 1 May 2023 17:39:02 GMT, Matthew Donovan wrote:
> In this PR, I added methods to the TransportContext class to synchronize
> access to the handshakeContext field. I also updated locations in the code
> that rely on the handshakeContext field to not be null to use the
> synchronized met
On Tue, 2 May 2023 14:31:38 GMT, Matthew Donovan wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized
On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote:
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
> files to specify `Locale.ROOT` to ensure that case conversion issues don't
> occur,
>
> I didn't add any new tests but ran tier 1-3 with no issues
Looks gener
Please find here a change that revisits usage of monitors in the HttpClient.
With Virtual Threads now part of the platform it should be possible to pass a
newVirtualThreadPerTaskExecutor to the HttpClient. Logging, when called from a
synchronized block, can cause the carrier thread to get pinned
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote:
> When using HttpClient to make requests to HTTPS resources, there is an issue
> where the entire file is being downloaded into memory without the ability to
> limit the buffer size.
> If the SSLEngine cannot decode the entire buffer due to the alg
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote:
> When using HttpClient to make requests to HTTPS resources, there is an issue
> where the entire file is being downloaded into memory without the ability to
> limit the buffer size.
> If the SSLEngine cannot decode the entire buffer due to the alg
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote:
> When using HttpClient to make requests to HTTPS resources, there is an issue
> where the entire file is being downloaded into memory without the ability to
> limit the buffer size.
> If the SSLEngine cannot decode the entire buffer due to the alg
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote:
> When using HttpClient to make requests to HTTPS resources, there is an issue
> where the entire file is being downloaded into memory without the ability to
> limit the buffer size.
> If the SSLEngine cannot decode the entire buffer due to the alg
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
src/java
On Fri, 16 Jun 2023 12:45:58 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 1438:
>>
>>> 1436:
>>> 1437: if (entry.attributes == null) {
>>> 1438: entry.attributes = ConcurrentHashMap.newKeySet();
>>
>> It seems that
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote:
> Main changes are to use 21 instead of 21-ea. In addition the following files
> contain additional updates from the closed sources:
>
> - src/java.base/share/man/java.1
>
> [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
The java/net/httpclient/HttpClientLocalAddrTest.java has been observed failing
relatively frequently in timeout - and the log shows a Carrier thread being
pinned.
Whether that's the root cause of the test failure is hard to say, but we should
fix the code to avoid pinned threads. This is one pat
On Fri, 15 Sep 2023 12:16:10 GMT, Daniel Fuchs wrote:
> The java/net/httpclient/HttpClientLocalAddrTest.java has been observed
> failing relatively frequently in timeout - and the log shows a Carrier thread
> being pinned.
> Whether that's the root cause of the test failure is
On Thu, 7 Sep 2023 21:54:44 GMT, Tim Prinzing wrote:
> No. I think it's a relic from the distant past though. I think the timeout
> field should be removed. It's not used on SocketChannel at all, and it
> doesn't seem useful on Socket.
Should we log an RFE to that effect?
-
PR Re
On Thu, 7 Sep 2023 21:50:17 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added stat
On Tue, 19 Sep 2023 20:51:41 GMT, Tim Prinzing wrote:
> The existing JFR tests TestSocketChannelEvents and TestSocketEvents in
> jdk.jfr.event.io verify the events are still emitted as expected.
Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
-
PR Com
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote:
> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>
> Still haven't made the attributes set immutable but at least it is populated
> before an entry is added to `entries` and it will never be modified later.
>
> I
On Tue, 26 Sep 2023 15:04:44 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 1270:
>>
>>> 1268: }
>>> 1269: Entry entry = entries.get(alias.toLowerCase(Locale.ENGLISH));
>>> 1270: return Collections.unmodifiableS
On Wed, 27 Sep 2023 13:07:00 GMT, Bart Smits wrote:
>> Hello @zhurs, would you mind if one of us took over this PR and moved this
>> forward? Daniel noted that the fix looks reasonable and it's the test which
>> will need some work. We will add you as the co-author.
>
> Hi @jaikiran I see the P
On Wed, 8 Nov 2023 05:34:47 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:
>>
>>> 60: if (ExceptionThrownEvent.enabled()) {
>>> 61: long timestamp = ExceptionThrownEvent.timestamp();
>>> 62: ExceptionThrownE
On Tue, 19 Dec 2023 16:00:09 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/event/SerializationMisdeclarationEvent.java
>> line 94:
>>
>>> 92:
>>> 93: /*
>>> 94: * These constants are not final on purpose.
>>
>> Just curious - what's the purpose? I don't
On Tue, 19 Dec 2023 19:39:22 GMT, Roger Riggs wrote:
>> What about fixed `String`s rather than `int`s for the kind of error?
>> Something like `"SUID_INEFFECTIVE_ON_ENUM"`, and so on?
>> It would be nice to be able to use enums, but AFAIK that's not supported in
>> JFR.
>
> You could define them
On Tue, 9 Jan 2024 10:42:58 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 87:
>>
>>> 85: }
>>> 86: if (cl.isEnum()) {
>>> 87: commitEvent(cl, SUID_NAME + " in an enum class is not
>>> effectiv
On Tue, 9 Jan 2024 10:46:27 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 70:
>>
>>> 68: privilegedCheckAccessibleMethod(cl, WRITE_REPLACE_NAME,
>>> 69: WRITE_REPLACE_PARAM_TYPES, Object.cl
On Wed, 17 Jan 2024 23:41:53 GMT, Weijun Wang wrote:
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject diffe
On Wed, 17 Jan 2024 23:41:53 GMT, Weijun Wang wrote:
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject diffe
On Tue, 30 Jan 2024 13:53:37 GMT, Daniel Fuchs wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Tue, 6 Feb 2024 17:29:25 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/sun/net/www/MessageHeader.java line 53:
>>
>>> 51: }
>>> 52:
>>> 53: @SuppressWarnings("this-escape")
>>
>> An alternative here could be to make the class final. AFAICS it's not
>> subclassed anywhere. If
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote:
> Currently these tests ignore vm flags, In most cases I've updated them to use
> `ProcessTools.createTestJavaProcessBuilder` this usually required some
> cleanup also.
>
> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Mon, 12 Feb 2024 10:58:45 GMT, Darragh Clarke wrote:
>> test/jdk/java/net/URLClassLoader/getresourceasstream/TestDriver.java line 63:
>>
>>> 61: ),
>>> 62: ProcessTools.createTestJavaProcessBuilder(
>>> 63: "-cp", ".",
>>
>> If I'm not
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
1 - 100 of 246 matches
Mail list logo
