On Tue, 2 May 2023 14:31:38 GMT, Matthew Donovan <d...@openjdk.org> wrote:

>> In this PR, I added methods to the TransportContext class to synchronize 
>> access to the handshakeContext field. I also updated locations in the code 
>> that rely on the handshakeContext field to not be null to use the 
>> synchronized methods.
>> 
>> Thanks
>
> Matthew Donovan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   using try/finally in terminateHandshakeContext and using local context 
> variable in all places it should be

src/java.base/share/classes/sun/security/ssl/TransportContext.java line 91:

> 89:     // handshake context
> 90:     HandshakeContext                handshakeContext = null;
> 91:     Lock                            handshakeCtxLock = new 
> ReentrantLock();

`handshakeCtxLock` should be declared final.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13742#discussion_r1182634866

Reply via email to