Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-28 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections

2025-05-28 Thread Mikhail Yankelevich
On Fri, 23 May 2025 18:41:17 GMT, Weijun Wang wrote: > Several changes are made: > > 1. The "include" and "includedir" directives can appear everywhere, even > inside a section or a sub-section. However, it only means the content is > inserted here but the included file still need its own full

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:07:45 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >> - update >> - reduced number of new

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:40:39 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >> - update >> - reduced number of new

RFR: 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir

2025-05-28 Thread Nibedita Jena
Generate intermediate/temporary files into the work directory, not in the test source directory. - Commit messages: - removed whitespace - 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir Changes: https://git.openjdk.org/jdk/

Withdrawn: 8347067: Load certificates without explicit trust settings in KeyChainStore

2025-05-28 Thread duke
On Fri, 3 Jan 2025 11:28:01 GMT, Tim Jacomb wrote: > ## The change > > Without this change intermediate certificates that don't have explicit trust > settings are ignored not added to the truststore. > > > > ## Reproducer > > See https://github.com/timja/openjdk-intermediate-ca-reproducer >

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Anthony Scarpino
On Wed, 28 May 2025 16:40:44 GMT, Artur Barashev wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> PEM reading tweak > > test/jdk/java/security/PEM/PEMDecoderTest.java line 1: > >> 1: /* > > Per RFC 7468: `pars

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v22]

2025-05-28 Thread Anthony Scarpino
On Thu, 22 May 2025 12:02:28 GMT, Krushna948 wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - comments >> - comments >> - fix EKS error after JEP 513 > > src/java.base/share/classes/java/security/PEMDecode

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v20]

2025-05-28 Thread Anthony Scarpino
On Thu, 22 May 2025 12:19:45 GMT, Krushna948 wrote: >> If this instance was configured with decryption, this method will return a >> new instance configured with decryption and the factory provider. I use "a >> copy" so the user knows they are adding a new configuration and this >> instance i

Re: RFR: 8349400: Improve startup speed via eliminating nested classes [v2]

2025-05-28 Thread Valerie Peng
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote: >> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 >> anonymous classes, which slows down the startup. This PR is to improve >> KnownOIDs and eliminate unnecessary embedded classes. >> >> >> Here's how to reproduce this:

Re: RFR: 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir

2025-05-28 Thread Mikhail Yankelevich
On Wed, 28 May 2025 17:52:31 GMT, Nibedita Jena wrote: > Generate intermediate/temporary files into the work directory, not in the > test source directory. test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java line 26: > 24: /* > 25: * @test > 26: * @bug 8350830 8357253 AFA

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Sean Mullan
On Tue, 27 May 2025 23:00:59 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK25 as a Preview Feature. Preview featur

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Weijun Wang
On Tue, 27 May 2025 23:00:59 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK25 as a Preview Feature. Preview featur

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Jamil Nimeh
On Tue, 27 May 2025 23:00:59 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK25 as a Preview Feature. Preview featur

Integrated: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview)

2025-05-28 Thread Anthony Scarpino
On Wed, 24 Jan 2024 00:01:06 GMT, Anthony Scarpino wrote: > Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK25 as a Preview Feature. Preview features do

Re: RFR: 8349550: Improve SASL random usage [v2]

2025-05-28 Thread Sean Mullan
On Wed, 28 May 2025 04:50:39 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Check Digest-MD5 utilities SecureRandom Usage and update random usage with >> secure random > > Koushik Muthukrishnan Thirupattur has updated the pull request incrementally > with one additional commit since the last

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 07:55:52 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Restore MenuShortcut.java >> - Restore LocaleDataTest.java > > test/jdk/java/awt/event/KeyEvent/KeyTyped

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 08:07:19 GMT, Magnus Ihse Bursie wrote: >> test/jdk/java/awt/font/TextLayout/RotFontBoundsTest.java line 63: >> >>> 61: >>> 62: private static final String INSTRUCTIONS = >>> 63: "A string \u201C" + TEXT + "\u201D is drawn at eight >>> different " >> >> I r

Re: RFR: 8357033: Reduce stateless session ticket size [v13]

2025-05-28 Thread Artur Barashev
On Thu, 29 May 2025 00:39:30 GMT, Bradford Wetmore wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comments. Optimize imports. > > test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java line 107:

Re: RFR: 8357033: Reduce stateless session ticket size [v13]

2025-05-28 Thread Bradford Wetmore
On Thu, 29 May 2025 01:58:37 GMT, Artur Barashev wrote: >> test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java line 107: >> >>> 105: >>> 106: switch (testMode) { >>> 107: case BASIC: >> >> Minor nit, Oracle Code Style is (was?) to keep case at the same level as

Re: RFR: 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir [v2]

2025-05-28 Thread Nibedita Jena
> Generate intermediate/temporary files into the work directory, not in the > test source directory. Nibedita Jena has updated the pull request incrementally with one additional commit since the last revision: Removed test bug number - Changes: - all: https://git.openjdk.org/j

RFR: 8228773: URLClassLoader constructors should include API note warning that the parent should not be null

2025-05-28 Thread Jaikiran Pai
Can I please get a review of this doc-only change which proposes to add an `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to explain the current implementation of these constructors? This addresses https://bugs.openjdk.org/browse/JDK-8228773? As noted in that issue,

Withdrawn: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-05-28 Thread duke
On Mon, 17 Mar 2025 13:19:55 GMT, Fernando Guallini wrote: > The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to > complete. The reason is that, in multiple scenarios, the server/client socket > times out after 10 seconds waiting to receive a DatagramPacket that has been

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Mark Reinhold
On Tue, 27 May 2025 23:00:59 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK25 as a Preview Feature. Preview featur

Re: RFR: 8298420: Implement JEP 470: PEM Encodings of Cryptographic Objects (Preview) [v24]

2025-05-28 Thread Artur Barashev
On Tue, 27 May 2025 23:00:59 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK25 as a Preview Feature. Preview featur

Re: RFR: 8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections [v2]

2025-05-28 Thread Weijun Wang
> Several changes are made: > > 1. The "include" and "includedir" directives can appear everywhere, even > inside a section or a sub-section. However, it only means the content is > inserted here but the included file still need its own full structure -- from > section to subsections. > 2. The

Re: RFR: 8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections [v2]

2025-05-28 Thread Weijun Wang
On Wed, 28 May 2025 11:18:21 GMT, Mikhail Yankelevich wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more random testing > > src/java.security.jgss/share/classes/sun/security/krb5/Config.java line 774: > >> 772:

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-28 Thread Mikhail Yankelevich
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check Still needs a review ---

Re: RFR: 8349550: Improve SASL random usage [v3]

2025-05-28 Thread Koushik Muthukrishnan Thirupattur
> Check Digest-MD5 utilities SecureRandom Usage and update random usage with > secure random Koushik Muthukrishnan Thirupattur has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Th

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-28 Thread Mark Sheppard
On Wed, 28 May 2025 11:13:12 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8357033: Reduce stateless session ticket size [v13]

2025-05-28 Thread Bradford Wetmore
On Tue, 27 May 2025 14:00:07 GMT, Artur Barashev wrote: >> The stateless session ticket is included in the ClientHello message, either >> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key >> extension (TLS1.3). With the current construction, the ticket is often the >> la

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v27]

2025-05-28 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is complete/approved. > > Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_securi