On Wed, 28 May 2025 16:40:44 GMT, Artur Barashev <abaras...@openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   PEM reading tweak
>
> test/jdk/java/security/PEM/PEMDecoderTest.java line 1:
> 
>> 1: /*
> 
> Per RFC 7468: `parsers SHOULD ignore whitespace and other non-base64 
> characters and MUST handle different newline conventions.`. Do we have a 
> coverage for those 2 test cases?

Base64 parsing is left to the Base64 API, the whitespace is removed during 
read, and we do have different newlines conventions.  I don't believe any new 
tests are needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2112418296

Reply via email to