On Wed, 14 May 2025 17:18:35 GMT, Justin Lu wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties
>> line 39:
>>
>>> 37: GTKColorChooserPanel.hue.textAndMnemonic=&Teinte :
>>> 38:
>>> 39: GTKColorChooserPanel.red.textAndMnemonic=Roug&e\u00a0:
>>
>> S
Non-breaking space characters are problematic. They look identical to the
normal space character, but is not. For that reason, it should never be typed
as an UTF-8 literal, but only by using unicode sequences.
I have checked:
* U+00A0 NO-BREAK SPACE (NBSP)
* U+202F NARROW NO-BREAK SPACE (NNBSP)
> When the deafult SunX509KeyManagerImpl is being used we are in violation of
> TLSv1.3 RFC spec because we ignore peer supported certificate signatures sent
> to us in "signature_algorithms"/"signature_algorithms_cert" extensions:
> https://datatracker.ietf.org/doc/html/rfc8446#section-4.4.2.2
>
On Wed, 14 May 2025 19:17:15 GMT, Daniel Jeliński wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 32
On Tue, 13 May 2025 17:15:39 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/java/security/DEREncodable.java line 37:
>
>> 35:
>> 36: /**
On Tue, 13 May 2025 22:28:48 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/PEMDecoder.java line 464:
>>
>>> 462: *
>>> 463: * If {@code provider} is {@code null}, a new instance is
>>> returned with
>>> 464: * the default provider configuration.
>>
>> IMHO
On Tue, 13 May 2025 07:37:06 GMT, Krushna948 wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line
> 369:
>
>> 367
On Tue, 6 May 2025 20:49:10 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 66 commits:
>>
>> - major code review comments update
>> - Merge branch 'master' into pem
>> - Merge branch
> Hi all,
>
> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format
> for encoding and decoding cryptographic keys and certificates. It will be
> integrated into JDK24 as a Preview Feature. Preview features does not
> permanently define the API and it is subject to cha
On Mon, 12 May 2025 14:35:45 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/conf/security/java.security line 1560:
>
>> 1558: # withEncryption met
On Tue, 13 May 2025 02:21:16 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/java/security/PEMEncoder.java line 95:
>>
>>> 93: * RFC 1421: Privacy Enhancement for Internet Electronic Mail
>>> 94: * @spec https://www.rfc-editor.org/info/rfc5958
>>> 95: * RFC 5958: Asym
On Tue, 13 May 2025 22:13:13 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 61:
>
>> 59: *
>> 60: *
>> 61: * I
On Tue, 4 Mar 2025 13:07:37 GMT, Fernando Guallini
wrote:
> The following tests are marked with @ignore (not running):
>
> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting
> the clientMode after the handshake has begun is not permitted, but this was
> failing interm
On Wed, 14 May 2025 21:42:06 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 329:
>>
>>> 327: */
>>> 328:
>>> 329: SSLSessionImpl(HandshakeContext hc, ByteBuffer buf) throws
>>> IOException {
>>
>> this constructor is used for ses
On Tue, 13 May 2025 21:44:21 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Missed one review comment
>> - More cod
On Tue, 13 May 2025 13:23:16 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1598:
>
>> 1596
On Wed, 14 May 2025 17:34:45 GMT, Naoto Sato wrote:
>> For the l10n files, they are synced by the translation team and we don't
>> edit them. IMO, I think it's fine leaving those ones as is. Especially
>> because language rules can cause different spacing and punctuation
>> characters, so gene
On Tue, 13 May 2025 13:25:21 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1650:
>
>> 1648
On Tue, 13 May 2025 12:16:37 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java line 189:
>
>> 187:
On Tue, 13 May 2025 13:37:18 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1682:
>
>> 1680
On Thu, 15 May 2025 02:25:30 GMT, Sergey Bylokhov wrote:
>> I believe it is OK to leave these as UTF-8 native characters, as these files
>> are l10n resource bundles. If we wanted to replace those look-alike spaces
>> to unicode escapes, other characters may also need the same treatment, such
> Hi all,
>
> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format
> for encoding and decoding cryptographic keys and certificates. It will be
> integrated into JDK24 as a Preview Feature. Preview features does not
> permanently define the API and it is subject to cha
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Wed, 14 May 2025 16:00:55 GMT, Sandhya Viswanathan
wrote:
>> Actually, the Java version is the one that is too cautious. There is Barrett
>> reduction after at most 4 consecutive uses of mlKemAddPoly(), so doing the
>> reduction in implKyberAddPoly() is not necessary. Thanks for discovering
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Wed, 14 May 2025 11:41:30 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 696:
>>
>>> 694: address generate_kyberAddPoly_2_avx512(StubGenerator *stubgen,
>>> 695:MacroAssembler *_masm) {
>>> 696:
>>
>> The Java co
I found a few other places in the code that can be cleaned up after the
conversion to UTF-8.
-
Commit messages:
- Replace uncessary unicode characters with ASCII in instructions, and fix typo
- Seems like typos in the comments
- Fix unicode sequences in comments (previously missed
On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
>> API (jck:api/java_security jck:
On Wed, 14 May 2025 15:11:24 GMT, Magnus Ihse Bursie wrote:
> Non-breaking space characters are problematic. They look identical to the
> normal space character, but is not. For that reason, it should never be typed
> as an UTF-8 literal, but only by using unicode sequences.
>
> I have checked
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Wed, 14 May 2025 16:59:23 GMT, Phil Race wrote:
>> Non-breaking space characters are problematic. They look identical to the
>> normal space character, but is not. For that reason, it should never be
>> typed as an UTF-8 literal, but only by using unicode sequences.
>>
>> I have checked:
>>
On Fri, 9 May 2025 15:37:44 GMT, Ben Perez wrote:
> Added custom multi array allocation function to improve performance
Marked as reviewed by weijun (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25151#pullrequestreview-284090
On Fri, 9 May 2025 15:37:44 GMT, Ben Perez wrote:
> Added custom multi array allocation function to improve performance
This pull request has now been integrated.
Changeset: ecabea6c
Author:Ben Perez
URL:
https://git.openjdk.org/jdk/commit/ecabea6cd315eaf08571ef61ff267318140d147b
St
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Tue, 13 May 2025 17:53:50 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restoring copyright notice on ML_KEM.java
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 693:
>
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
Respond
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Wed, 14 May 2025 11:36:46 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> src/java.base/share/classes/java/security/PEMRecord.java line 119:
>
>> 117:
>> 118: * @param ty
On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Tue, 13 May 2025 17:13:03 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java line
> 62
On Wed, 14 May 2025 11:49:11 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 15 May 2025 00:23:56 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1583:
>>
>>> 1581: // Calculations are primarily based on protocol version.
>>> 1582: switch (protocolVersion) {
>>> 1583: case TLS13: // HK
On Wed, 14 May 2025 20:13:36 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 172
On Wed, 14 May 2025 15:52:34 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> src/java.base/share/classes/java/security/DEREncodable.java line 41:
>
>> 39: * These APIs or their s
On Wed, 14 May 2025 13:16:17 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 61:
>
>> 59: *
>> 60: *
>> 61: * >I
On Mon, 5 May 2025 13:12:11 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 66 commits:
>>
>> - major code review comments update
>> - Merge branch 'master' into pem
>> - Merge branch
On Mon, 12 May 2025 20:36:40 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/java/security/PEMRecord.java line 129:
>
>> 127: *
>> 128
On Tue, 13 May 2025 21:46:26 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/java/security/PEMRecord.java line 48:
>
>> 46: *
>> 47: * D
On Mon, 12 May 2025 18:49:56 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/java/security/PEMRecord.java line 101:
>
>> 99: // inc
On Sun, 27 Apr 2025 19:10:31 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/java/security/PEMDecoder.java line 213:
>>
>>> 211: Objects.requireNonNull(str);
>>> 212: try {
>>> 213: return decode(new ByteArrayInputStream(str.getBytes()));
>>
>> `str.getB
On Thu, 8 May 2025 21:32:13 GMT, Weijun Wang wrote:
>> There is an inconsistency with PEMRecord here. These methods should not
>> allow leadingData if it is not available elsewhere. I will redo that.
>> leadingData can be reserved for the decode methods that take a class.
>>
>> I tried not
On Wed, 14 May 2025 11:38:15 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/PEMRecord.java line 119:
>>
>>> 117:
>>> 118: * @param type the PEM type identifier
>>> 119: * @param pem the Base64-encoded data encapsulated by the PEM
>>> header and
>>
>> Since inte
53 matches
Mail list logo
