Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-05 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-05 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-05 Thread Sandhya Viswanathan
On Wed, 5 Mar 2025 23:03:23 GMT, Volodymyr Paprotski wrote: >> Add AVX2 montgomery multiplication intrinsic. (About 60-80% gain) >> >> Also add reduction to existing AVX512 multiplication (this was left-over >> from https://github.com/openjdk/jdk/pull/19893 where a quick fix was >> required).

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v2]

2025-03-05 Thread Jatin Bhateja
On Mon, 3 Mar 2025 19:00:59 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v3]

2025-03-05 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request with a new target base due to a merge or a rebase. The pull requ

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v3]

2025-03-05 Thread Ferenc Rakoczi
On Wed, 5 Mar 2025 11:39:05 GMT, Jatin Bhateja wrote: >> Ferenc Rakoczi has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merged master. >> - Added comments, removed debugging printfs >> - JDK-8351034 Add A

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v4]

2025-03-05 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

Re: [External] : Re: Certificate Transparency—basic support for the TLS extension?

2025-03-05 Thread Ivan Ristic
Yes, the source is important as different policy rules can apply, depending on the source. I think that, if aiming for a complete SCT support, it would be absolutely prudent to include a reference to the relevant certificate from the handshake. That said, I don't think anyone is including SCTs in

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v3]

2025-03-05 Thread Jatin Bhateja
On Wed, 5 Mar 2025 11:33:06 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request wi

Re: RFR: 8351223: Update localized resources in keytool and jarsigner

2025-03-05 Thread Justin Lu
On Wed, 5 Mar 2025 14:45:34 GMT, Weijun Wang wrote: >> Please review this PR which provides localization updates for resources in >> `jarsigner` and `keytool`. >> The key/vals in this PR are updated to match the changes made in the English >> source files. >> Further context is provided on the

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v3]

2025-03-05 Thread Ferenc Rakoczi
On Wed, 5 Mar 2025 14:03:00 GMT, Jatin Bhateja wrote: >> Hi, @jatin-bhateja, thanks for the suggestion. I have added __ >> align(OptoLoopAlignment); before all loop entries. > > Hi @ferakocz , > > Thanks!, for efficient utilization of Decode ICache (please refer to Intel > SDM section 3.4.2.5

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-03-05 Thread Matthew Donovan
On Wed, 19 Feb 2025 17:03:02 GMT, Fernando Guallini wrote: >> This updates the OpenSSL version that is used by test >> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS >> version (3.0 series). >> There are some differences between the 1.1.x and the current OpenSSL versi

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v3]

2025-03-05 Thread Jatin Bhateja
On Wed, 5 Mar 2025 13:07:54 GMT, Ferenc Rakoczi wrote: >> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 292: >> >>> 290: __ movl(iterations, 2); >>> 291: >>> 292: __ BIND(L_loop); >> >> Hi @ferakocz , Kindly align loop entry address using __align64() here and at >> all the p

Re: RFR: 8351223: Update localized resources in keytool and jarsigner

2025-03-05 Thread Matthew Donovan
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote: > Please review this PR which provides localization updates for resources in > `jarsigner` and `keytool`. > The key/vals in this PR are updated to match the changes made in the English > source files. > Further context is provided on the JBS iss

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

2025-03-05 Thread Matthew Donovan
On Tue, 4 Mar 2025 13:07:37 GMT, Fernando Guallini wrote: > The following tests are marked with @ignore (not running): > > - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting > the clientMode after the handshake has begun is not permitted, but this was > failing interm

Re: RFR: 8351223: Update localized resources in keytool and jarsigner

2025-03-05 Thread Weijun Wang
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote: > Please review this PR which provides localization updates for resources in > `jarsigner` and `keytool`. > The key/vals in this PR are updated to match the changes made in the English > source files. > Further context is provided on the JBS iss

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v4]

2025-03-05 Thread Anthony Scarpino
> Hi, > > I need a review for the following change. Naming conventions for EdDSA and > XDH have inconsistencies between DisabledAlgorithms and KeyPairGenerator. > These internal changes help make it more consistent when parsing the actual > curve being used vs the broader algorithm name. > > t

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-05 Thread Volodymyr Paprotski
> Add AVX2 montgomery multiplication intrinsic. (About 60-80% gain) > > Also add reduction to existing AVX512 multiplication (this was left-over from > https://github.com/openjdk/jdk/pull/19893 where a quick fix was required). > This is mostly for cleanup, but there is about 1-2% gain. > > Befo

Re: RFR: 8351223: Update localized resources in keytool and jarsigner

2025-03-05 Thread Weijun Wang
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote: > Please review this PR which provides localization updates for resources in > `jarsigner` and `keytool`. > The key/vals in this PR are updated to match the changes made in the English > source files. > Further context is provided on the JBS iss

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-03-05 Thread Matthew Donovan
On Wed, 19 Feb 2025 17:03:02 GMT, Fernando Guallini wrote: >> This updates the OpenSSL version that is used by test >> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS >> version (3.0 series). >> There are some differences between the 1.1.x and the current OpenSSL versi

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-03-05 Thread Fernando Guallini
On Wed, 5 Mar 2025 19:45:14 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated wording of openssl version > > test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 78: > >

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v11]

2025-03-05 Thread Sean Mullan
On Sat, 1 Mar 2025 00:00:21 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> ![image](https://github.com/user-attachments/assets/0c9a79f3-4cb

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v12]

2025-03-05 Thread Koushik Muthukrishnan Thirupattur
> java.security.debug is a widely used debug system property for JDK security > libs. It's time to capture details about this property via javadoc. > > ![image](https://github.com/user-attachments/assets/0c9a79f3-4cb2-414c-af1d-eac2590740ea) > > > NOTE : We are adding a new html file (similar t