Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 17:50:19 GMT, Kevin Driver wrote: >> I'd recommend documenting above this line what function the lock is >> intending to serve, and by each of the members that it guards accesses to. >> Something like "//guarded by 'lock'". >> >> Also, ook into whether the members guarded by

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v5]

2024-09-06 Thread Ferenc Rakoczi
On Wed, 28 Aug 2024 18:18:22 GMT, Valerie Peng wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing typos and simplify the squeeze() method as suggested by Weijun > > src/java.base/share/classes/sun/security/pr

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v6]

2024-09-06 Thread Ferenc Rakoczi
> In preparation for the new PQC algorithms implementations, internal XOF > (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 > implementations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Addressing

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v5]

2024-09-06 Thread Ferenc Rakoczi
On Wed, 28 Aug 2024 16:42:38 GMT, Ferenc Rakoczi wrote: >> In preparation for the new PQC algorithms implementations, internal XOF >> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 >> implementations. > > Ferenc Rakoczi has updated the pull request incrementally wit

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 12:51:10 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 13:27:05 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v25]

2024-09-06 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v26]

2024-09-06 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 14:07:47 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits si

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v6]

2024-09-06 Thread Valerie Peng
On Fri, 6 Sep 2024 14:13:15 GMT, Ferenc Rakoczi wrote: >> In preparation for the new PQC algorithms implementations, internal XOF >> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 >> implementations. > > Ferenc Rakoczi has updated the pull request incrementally with

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 13:31:07 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v27]

2024-09-06 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 14:06:08 GMT, Viktor Klang wrote: >> My understanding is that `volatile` is used when accessing the contents of >> the object, which we are not doing with this locking object, so IMO there is >> no reason for the keyword to be added. >> >> I'll apply your other suggestion ab

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Kevin Driver
On Fri, 6 Sep 2024 14:06:51 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits si