> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "unspecified". This PR adds checks to ensure
> that transf
On Mon, 7 Jul 2025 21:08:55 GMT, Valerie Peng wrote:
>> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
>> transformation should be either "algorithm/mode/padding" or
>> "algorithm". When parsing the transformation, space(s) is trimmed off and
>> empty strings are considered as
On Wed, 2 Jul 2025 19:19:10 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated to use List.of() per Sean's comment.
>
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 27:
>
>> 25
On Wed, 2 Jul 2025 16:31:55 GMT, Valerie Peng wrote:
>> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
>> transformation should be either "algorithm/mode/padding" or
>> "algorithm". When parsing the transformation, space(s) is trimmed off and
>> empty strings are considered as
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "unspecified". This PR adds checks to ensure
> that transf
On Tue, 1 Jul 2025 22:42:11 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated test per 2nd round of Mikhail's review comments.
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 47
On Wed, 18 Jun 2025 06:27:13 GMT, Valerie Peng wrote:
>> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
>> transformation should be either "algorithm/mode/padding" or
>> "algorithm". When parsing the transformation, space(s) is trimmed off and
>> empty strings are considered as
On Tue, 17 Jun 2025 10:21:42 GMT, Mikhail Yankelevich
wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated test per Mikhail's review comments.
>
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 37:
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "unspecified". This PR adds checks to ensure
> that transf
On Tue, 17 Jun 2025 10:21:40 GMT, Mikhail Yankelevich
wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated test per Mikhail's review comments.
>
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 30:
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "unspecified". This PR adds checks to ensure
> that transf
On Mon, 16 Jun 2025 21:32:16 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/Cipher.java line 348:
>>
>>> 346: transformation.substring(0, endIdx).trim());
>>> 347: if (algo.isEmpty()) {
>>> 348: throw new NoSuchAlgorithmException("Invalid
On Mon, 16 Jun 2025 22:20:10 GMT, Valerie Peng wrote:
>> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
>> transformation should be either "algorithm/mode/padding" or
>> "algorithm". When parsing the transformation, space(s) is trimmed off and
>> empty strings are considered as
On Mon, 16 Jun 2025 13:49:38 GMT, Mikhail Yankelevich
wrote:
>> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
>> transformation should be either "algorithm/mode/padding" or
>> "algorithm". When parsing the transformation, space(s) is trimmed off and
>> empty strings are consi
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "unspecified". This PR adds checks to ensure
> that transf
On Fri, 13 Jun 2025 17:32:12 GMT, Valerie Peng wrote:
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher
> transformation should be either "algorithm/mode/padding" or
> "algorithm". When parsing the transformation, space(s) is trimmed off and
> empty strings are considered as "un
16 matches
Mail list logo