On Tue, 8 Apr 2025 21:27:08 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Wed, 9 Apr 2025 17:09:09 GMT, Ferenc Rakoczi wrote:
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
> That is in no small part thanks to the reviewers, especially to
On Wed, 9 Apr 2025 17:09:09 GMT, Ferenc Rakoczi wrote:
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
> That is in no small part thanks to the reviewers, especially to
On Tue, 8 Apr 2025 21:58:57 GMT, Sandhya Viswanathan
wrote:
> Overall very clean and nicely done PR. Thanks a lot for considering my inputs.
That is in no small part thanks to the reviewers, especially to Volodymyr!
@lmesnik, @jatin-bhateja, @sviswa7 would one of you /sponsor me with the
integ
On Tue, 8 Apr 2025 21:27:08 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Sat, 5 Apr 2025 00:27:05 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reacting to comment by Sandhya.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 345:
>
>> 343
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Wed, 2 Apr 2025 07:38:34 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Tue, 1 Apr 2025 22:43:36 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reacting to comments by Volodymyr.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 359:
>
>> 357:
On Sat, 22 Mar 2025 16:36:08 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix windows build
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 121:
>
>> 119: static void
On Mon, 31 Mar 2025 11:11:54 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/x86/vm_version_x86.cpp line 1252:
>>
>>> 1250: // Currently we only have them for AVX512
>>> 1251: #ifdef _LP64
>>> 1252: if (supports_evex() && supports_avx512bw()) {
>>
>> supports_evex check looks redundant.
>
> T
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Wed, 2 Apr 2025 07:38:34 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Mar 2025 19:26:14 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Accepted review comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 409:
>
>> 407: __ evmo
On Wed, 2 Apr 2025 07:38:34 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 27 Mar 2025 21:42:08 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
> src/hotspot/cpu/x86/stubGenerator
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Mon, 31 Mar 2025 14:40:56 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 31 Mar 2025 14:40:56 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Sat, 22 Mar 2025 16:11:02 GMT, Volodymyr Paprotski
wrote:
>> These functions will not be used anywhere else and in ML_DSA.java all of the
>> arrays passed to inrinsics are of the correct size.
>
> Works for me; just thought I would point it out, so its a 'premeditated'
> decision.
Well, I
On Sun, 23 Mar 2025 00:26:20 GMT, Volodymyr Paprotski
wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 216:
>>
>>> 214: // Zmm8-Zmm23 used as scratch registers
>>> 215: // result goes to Zmm0-Zmm7
>>> 216: static void montMulByConst128(MacroAssembler *_masm) {
>>
>> wish t
On Mon, 17 Mar 2025 19:22:41 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Made the intrinsics test separate from the pure java test.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilit
On Mon, 24 Mar 2025 15:16:20 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
> I still need to have a look at th
On Sun, 23 Mar 2025 00:21:18 GMT, Volodymyr Paprotski
wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 119:
>>
>>> 117: static address dilithiumAvx512PermsAddr() {
>>> 118: return (address) dilithiumAvx512Perms;
>>> 119: }
>>
>> Hear me out.. ...
>> enums!!
>>
>> enum
On Mon, 24 Mar 2025 02:38:37 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
> src/hotspot/cpu/x86/vm_version_x86.cpp l
On Sat, 22 Mar 2025 16:45:31 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix windows build
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 216:
>
>> 214: // Zmm8-Zmm
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Sat, 22 Mar 2025 20:38:19 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
> src/hotspot/cpu/x86/stubGenerator
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Mar 2025 21:06:30 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 58:
>>
>>> 56:
>>> 57: ATTRIBUTE_ALIGNED(64) static const uint32_t dilithiumAvx512Perms[] = {
>>> 58: // collect montmul results into the destination register
>>
>> same
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Mar 2025 20:37:25 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since the last revisio
On Thu, 6 Mar 2025 19:27:12 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Accepted review comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 426:
>
>> 424: __ subl
On Mon, 17 Mar 2025 19:24:52 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Made the intrinsics test separate from the pure java test.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilit
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Thu, 6 Mar 2025 17:37:33 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Wed, 12 Mar 2025 19:19:08 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Wed, 12 Mar 2025 19:19:08 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Wed, 12 Mar 2025 15:34:18 GMT, Leonid Mesnik wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added validity test for the intrinsics.
>
> test/jdk/sun/security/provider/acvp/Launcher.java line 43:
>
>> 41: *
On Wed, 5 Mar 2025 13:10:34 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Wed, 12 Mar 2025 13:42:33 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 6 Mar 2025 14:30:35 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added alignment to loop entries.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 2:
>
>> 1: /*
>> 2:
On Thu, 6 Mar 2025 09:32:19 GMT, Jatin Bhateja wrote:
>> I think the easiest is to put a for (int i = 0; i < 1000; i++) loop around
>> the switch statement in the run() method of the ML_DSA_Test class
>> (test/jdk/sun/security/provider/acvp/ML_DSA_Test.java). (This is because the
>> intrinsi
On Mon, 10 Mar 2025 03:00:09 GMT, Leonid Mesnik wrote:
> There are no any new tests in the PR. How fix has been tested by openjdk
> tests?
I have just added one.
-
PR Comment: https://git.openjdk.org/jdk/pull/23860#issuecomment-2717950685
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Wed, 5 Mar 2025 18:27:44 GMT, Ferenc Rakoczi wrote:
>> Hi @ferakocz ,
>>
>> Thanks!, for efficient utilization of Decode ICache (please refer to Intel
>> SDM section 3.4.2.5), code blocks should be aligned to 32-byte boundaries; a
>> 64-byte aligned code is a superset of both 16 and 32 byt
On Thu, 6 Mar 2025 17:37:33 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Wed, 5 Mar 2025 13:10:34 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Thu, 6 Mar 2025 08:37:57 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added alignment to loop entries.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 85:
>
>> 83: if (UseSH
On Wed, 5 Mar 2025 14:03:00 GMT, Jatin Bhateja wrote:
>> Hi, @jatin-bhateja, thanks for the suggestion. I have added __
>> align(OptoLoopAlignment); before all loop entries.
>
> Hi @ferakocz ,
>
> Thanks!, for efficient utilization of Decode ICache (please refer to Intel
> SDM section 3.4.2.5
On Wed, 5 Mar 2025 11:33:06 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request wi
On Wed, 5 Mar 2025 13:07:54 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 292:
>>
>>> 290: __ movl(iterations, 2);
>>> 291:
>>> 292: __ BIND(L_loop);
>>
>> Hi @ferakocz , Kindly align loop entry address using __align64() here and at
>> all the p
On Wed, 5 Mar 2025 11:39:05 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merged master.
>> - Added comments, removed debugging printfs
>> - JDK-8351034 Add A
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Mon, 3 Mar 2025 19:00:59 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase. The pull requ
On Mon, 3 Mar 2025 19:00:59 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
By using the AVX-512 vector registers the speed of the computation of the
ML-DSA algorithms (key generation, document signing, signature verification)
can be approximately doubled.
-
Commit messages:
- JDK-8351034 Add AVX-512 intrinsics for ML-DSA
Changes: https://git.openjdk.org/
65 matches
Mail list logo
