On Thu, 6 Mar 2025 14:30:35 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added alignment to loop entries. > > src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 2: > >> 1: /* >> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. > > Please update copyright year Thanks, fixed. > src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 96: > >> 94: StubRoutines::_dilithiumMontMulByConstant = >> generate_dilithiumMontMulByConstant_avx512(); >> 95: StubRoutines::_dilithiumDecomposePoly = >> generate_dilithiumDecomposePoly_avx512(); >> 96: } > > Indentation fix needed Thanks, fixed. > src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 362: > >> 360: const Register roundsLeft = r11; >> 361: >> 362: __ align(OptoLoopAlignment); > > Redundant alignment before label should be before it's bind Thanks, fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r1991546308 PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r1991546488 PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r1991546606
