Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v5]

2025-04-10 Thread duke
On Thu, 10 Apr 2025 14:42:22 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v5]

2025-04-10 Thread Sean Mullan
On Thu, 10 Apr 2025 14:42:22 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-04-10 Thread Mikhail Yankelevich
On Thu, 10 Apr 2025 13:36:01 GMT, Sean Mullan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 57: > >> 55: final GSSManager mgr = GSSMan

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-04-10 Thread Sean Mullan
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor test/jdk/sun/security/krb5/Krb5NameEquals.java line

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v5]

2025-04-10 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the las

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-04-09 Thread Mark Powers
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor Looks good to me. IntelliJ couldn't find problems e

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-04-08 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor Still needs a review - PR Comment: ht

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-03-11 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor Still needs an approval - PR Comment:

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pull/23542

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v3]

2025-02-11 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 18:00:48 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > reworked Idea to check the availability of kerberos & code

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v3]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: reworked - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pull/23

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 11:29:59 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup test/jdk/sun/security/krb5/Krb5NameEquals.ja

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 11:29:59 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup test/jdk/sun/security/krb5/Krb5NameEquals.ja

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 13:22:08 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor cleanup > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 92: > >> 90: final var

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Mikhail Yankelevich
On Mon, 10 Feb 2025 18:23:35 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor cleanup > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 94: > >> 92: >> 93:

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-11 Thread Mikhail Yankelevich
On Mon, 10 Feb 2025 18:32:21 GMT, Matthew Donovan wrote: >> Refactored the runNameEquals.sh to java test > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 145: > >> 143: GSSName.NT_HOSTBASED_SERVICE, MECH); >> 144: >> 145: if (!name1.equals(name1) || !name1

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-10 Thread Matthew Donovan
On Mon, 10 Feb 2025 17:50:21 GMT, Mikhail Yankelevich wrote: > Refactored the runNameEquals.sh to java test test/jdk/sun/security/krb5/Krb5NameEquals.java line 94: > 92: > 93: if (installationIssue) { > 94: System.out.println(""" You should probably

RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-10 Thread Mikhail Yankelevich
Refactored the runNameEquals.sh to java test - Commit messages: - 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test Changes: https://git.openjdk.org/jdk/pull/23542/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23542&range=00 Issue: https://bugs.openj