On Mon, 10 Feb 2025 18:32:21 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> Refactored the runNameEquals.sh to java test > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 145: > >> 143: GSSName.NT_HOSTBASED_SERVICE, MECH); >> 144: >> 145: if (!name1.equals(name1) || !name1.equals(name3) || > > I don't know much about kerberos but is there ever a chance that > `name1.equals(name1)` is false? And the same with name3 which looks to be > created the same exact was as name1? Yes, you're right. Also name1.equals((Object) name1) is always false, so removing in the next commit ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23542#discussion_r1950661891
