On Mon, 10 Feb 2025 18:23:35 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor cleanup > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 94: > >> 92: >> 93: if (installationIssue) { >> 94: System.out.println(""" > > You should probably throw a SkippedException instead. The initial logic in the shell file passed the test, but I agree that skip exception is going to be better in this case ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23542#discussion_r1950671438