Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module [v2]

2024-11-14 Thread Roger Riggs
On Wed, 13 Nov 2024 20:27:01 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. > > Sean Mullan has updated the pull request incrementally

Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module [v2]

2024-11-13 Thread Sean Mullan
> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. Sean Mullan has updated the pull request incrementally with one additional commit since the last revision: Remo

Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module [v2]

2024-11-13 Thread Sean Mullan
On Wed, 13 Nov 2024 15:12:24 GMT, Roger Riggs wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove osName and osArch fields from Config. >> Remove getValue method from P11KeyAgreement. > > src/jdk.crypto.cryptok

Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module [v2]

2024-11-13 Thread Sean Mullan
On Wed, 13 Nov 2024 17:28:16 GMT, Anthony Scarpino wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove osName and osArch fields from Config. >> Remove getValue method from P11KeyAgreement. > > src/jdk.crypto.c

Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module

2024-11-13 Thread Anthony Scarpino
On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. One minor question, but it looks good as is. src/jdk.crypto

Re: RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module

2024-11-13 Thread Roger Riggs
On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. LGTM src/jdk.crypto.cryptoki/share/classes/sun/security/pkc

RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module

2024-11-13 Thread Sean Mullan
Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` implementation dependencies on `System.getSecurityManager` and `AccessController.doPrivileged` can be removed. - Commit messages: - Initial cleanup. Changes: https://git.openjdk.org/jdk/pull/22077/files Webrev: http