Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Sibabrata Sahoo
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Daniel Jeliński
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Sibabrata Sahoo
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Anthony Scarpino
> Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the > NewSessionTicket change in > [JDK-8328608](https://bugs.open

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Anthony Scarpino
On Tue, 25 Jun 2024 19:44:00 GMT, Daniel Jeliński wrote: >> I tried this and it caused a lockup in one of the tests. I see why your >> think this is the right change, but it isn't proving out in the testing > > That's very interesting! Which test was it? Was it with or without #19465? I do run

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Tue, 25 Jun 2024 18:26:40 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java line >> 171: >> >>> 169: for (int limit = (offset + length); offset < limit;) { >>> 170: >>> 171: int remains = (limit - offset) + (

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Anthony Scarpino
On Tue, 25 Jun 2024 08:14:10 GMT, Daniel Jeliński wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of the

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino wrote: > Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the >

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino wrote: > Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the >

RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-24 Thread Anthony Scarpino
Hi, I need a review to change the a fragment buffer size miscalculation error. This appears when there are large handshake messages and hasn't been observed during application data. This was found during testing of the NewSessionTicket change in [JDK-8328608](https://bugs.openjdk.org/browse/