Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v6]

2023-11-30 Thread Ferenc Rakoczi
On Thu, 16 Nov 2023 15:17:42 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reword comment > > src/java.base/share/classes/sun/security/util/KeyUtil.java line 411: > >> 409: * @throws NoSuchA

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v6]

2023-11-30 Thread Weijun Wang
On Thu, 30 Nov 2023 16:13:09 GMT, Ferenc Rakoczi wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reword comment > > src/java.base/share/classes/sun/security/pkcs/SignerInfo.java line 526: > >> 524:

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v6]

2023-11-30 Thread Ferenc Rakoczi
On Mon, 27 Nov 2023 20:21:33 GMT, Weijun Wang wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v6]

2023-11-27 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v5]

2023-11-27 Thread Sean Mullan
On Mon, 27 Nov 2023 14:09:42 GMT, Weijun Wang wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v5]

2023-11-27 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v4]

2023-11-24 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v3]

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 16:33:36 GMT, Sean Mullan wrote: >> This internal method was called by `TimestampedSigner` which was removed >> long ago when we removed the support for `ContentSigner` and `jarsigner >> -altsign`. It has been useless for some time and this is just a cleanup. > > Ok, I see.

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v3]

2023-11-16 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v2]

2023-11-16 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Thu, 16 Nov 2023 16:25:33 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 872: >> >>> 870: */ >>> 871: @Deprecated(since="16", forRemoval=true) >>> 872: public static byte[] generateSignedData(byte[] signature, >> >> Are you sure you want

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 15:36:08 GMT, Sean Mullan wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 15:45:38 GMT, Sean Mullan wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
Code changes for HSS/LMS that's related to keytool and jarsigner: 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it can only be `HSS/LMS`. 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same as the hash algorithm used by the HSS/LMS key. This nee