On Mon, 8 May 2023 14:14:42 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 16:38:01 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 528:
>>
>>> 526: // update()-digest() sequence) which is parametrized so that
>>> the digest output is copied back into this buffer.
>>> 527: // This way, we av
On Thu, 4 May 2023 21:13:24 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 16:16:23 GMT, Weijun Wang wrote:
>> Ok. Try to keep your line lengths to about 80 chars.
>
> I think so too. This class is only used by tests now so it will not have any
> negative performance impact on real users. If we want to move it into the
> public one day then we don't
On Thu, 4 May 2023 21:24:16 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 15:22:07 GMT, Sean Mullan wrote:
>> Yes, I think so. If someone wants to test with several different keys by
>> first creating RawKeySpec objects from an array in which a few bytes are
>> changed between the calls and and then use these KeySpecs to create the
>> actual keys,
On Mon, 8 May 2023 13:33:01 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/util/RawKeySpec.java line 37:
>>
>>> 35: */
>>> 36: public RawKeySpec(byte[] key) {
>>> 37: keyArr = key.clone();
>>
>> Does this need to be cloned if it is an internal class?
>
>
On Mon, 8 May 2023 13:32:38 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 823:
>>
>>> 821: index += siglist[i].sigArrayLength();
>>> 822: pubList[i] = new LMSPublicKey(sigArr, index,
>>> false);
>>> 823:
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 8 May 2023 15:02:55 GMT, Ferenc Rakoczi wrote:
>> Without that, I get:
>>
>> /Users/ferakocz/dev/git-repos/jdk/open/src/java.base/share/classes/sun/security/provider/HSS.java:813:
>> warning: [deprecation] key in X509Key has been deprecated
>> key = new
>> DerOutputStream()
On Mon, 8 May 2023 13:32:29 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 745:
>>
>>> 743:
>>> 744: @Override
>>> 745: protected T engineGetKeySpec(Key key,
>>> Class keySpec) throws InvalidKeySpecException {
>>
>> Usually when
On Mon, 8 May 2023 14:10:54 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 796:
>>
>>> 794:
>>> 795: @Override
>>> 796: @SuppressWarnings("deprecation")
>>
>> Why do you need the `SuppressWarnings` annotation here?
>> `sun.util.Le
On Mon, 8 May 2023 13:32:21 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 94:
>>
>>> 92: result &= lmsVerify(lmsPubKey, sig.siglist[sig.Nspk],
>>> messageStream.toByteArray());
>>> 93: return result;
>>> 94: } catch
On Mon, 8 May 2023 12:38:36 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 12:59:05 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Thu, 4 May 2023 20:00:18 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Fri, 5 May 2023 19:34:32 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 20:48:37 GMT, Weijun Wang wrote:
>> Done.
>
> Where?
Done now. Sorry about it.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1183075152
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
25 matches
Mail list logo
