Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v5]

2024-07-18 Thread duke
On Wed, 17 Jul 2024 15:42:11 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thou

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v5]

2024-07-17 Thread Bradford Wetmore
On Wed, 17 Jul 2024 15:42:11 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thou

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-07-17 Thread Bradford Wetmore
On Wed, 17 Jul 2024 21:43:22 GMT, Bradford Wetmore wrote: >> Yes, that was my concern, but I would prefer to keep relying on >> ProvidersSnapshot to revert to the original state. > > It's fine if you want to keep `ProvidersSnapshot`, but the `/othervm` is no > longer necessary, AFAICT. Ignore:

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-07-17 Thread Bradford Wetmore
On Wed, 17 Jul 2024 13:01:19 GMT, Fernando Guallini wrote: >> test/jdk/java/security/Security/SynchronizedAccess.java line 29: >> >>> 27: * @library /test/lib ../testlibrary >>> 28: * @summary Make sure Provider api implementations are synchronized >>> properly >>> 29: * @run main/othervm S

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v5]

2024-07-17 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-07-17 Thread Fernando Guallini
On Tue, 16 Jul 2024 00:37:17 GMT, Bradford Wetmore wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >>

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-07-16 Thread Bradford Wetmore
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-22 Thread Bradford Wetmore
On Thu, 20 Jun 2024 14:42:21 GMT, Fernando Guallini wrote: > hi @bradfordwetmore Could you please review this PR? Hi, just back from vacation, and busy until Tuesday at earliest. I'll put a note in calendar, but please ping me if I haven't responded by Thursday. - PR Comment: ht

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-20 Thread Fernando Guallini
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-06 Thread Rajan Halade
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-06 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v3]

2024-06-06 Thread Matthew Donovan
On Thu, 6 Jun 2024 13:13:00 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v3]

2024-06-06 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]

2024-06-06 Thread Fernando Guallini
On Thu, 6 Jun 2024 11:25:39 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]

2024-06-06 Thread Matthew Donovan
On Mon, 3 Jun 2024 09:54:16 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]

2024-06-03 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect

2024-05-30 Thread Fernando Guallini
As highlighted in the bug description, The test **security/Security/SynchronizedAccess.java** have some issues: 1. it needs to implement the sigalg, otherwise it throws java.security.NoSuchAlgorithmException . Even though it does not fail as it catches the exception, it never reaches the remove