On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini <fguall...@openjdk.org> wrote:
>> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even though it does not fail as it >> catches the exception, it never reaches the removeProvider loop. Also, >> adding an extra assertion to verify the local providers were actually >> removed. >> 2. It is reassigning the **provs** variable with Security.getProviders(). >> This will start adding/removing some of the system providers, in addition to >> the local providers, which it is not the test intent. >> 3. Adding othervm flag to run in isolation. >> >> Test runs in tier2 > > Fernando Guallini has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains two commits: > > - added brackets, and refactor a comment and an exception message > - Regtest java/security/Security/SynchronizedAccess.java is incorrect. LGTM. @bradfordwetmore Can you please also review the patch? ------------- Marked as reviewed by rhalade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19480#pullrequestreview-2103479111
