Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations [v2]

2022-07-18 Thread Weijun Wang
On Tue, 12 Jul 2022 03:02:16 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-4887998 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > second iteration Looks good to me. No more comment. - Marked

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations [v2]

2022-07-18 Thread Mark Powers
On Tue, 12 Jul 2022 03:02:16 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-4887998 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > second iteration Is there anything more that I need to check before integra

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations

2022-07-12 Thread Jatin Bhateja
On Tue, 12 Jul 2022 14:34:32 GMT, Weijun Wang wrote: >> 1. I tried to keep as much of the original parenthesis as possible. I can do >> the minimum number if that is what you prefer. >> 2. I'll change MD4, MD5, and SHA-1 to use `rotateLeft` in keeping with how >> they are described in their res

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations

2022-07-11 Thread Jatin Bhateja
On Tue, 12 Jul 2022 00:44:37 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-4887998 > > 1. I tried to keep as much of the original parenthesis as possible. I can do > the minimum number if that is what you prefer. > 2. I'll change MD4, MD5, and SHA-1 to use `rotateLeft` in keepin

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations [v2]

2022-07-11 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-4887998 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: second iteration - Changes: - all: https://git.openjdk.org/jdk/pull/9456/files - new: https://git.openjdk.org/jdk/pull/9456

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations

2022-07-11 Thread Mark Powers
On Mon, 11 Jul 2022 21:20:43 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-4887998 1. I tried to keep as much of the original parenthesis as possible. I can do the minimum number if that is what you prefer. 2. I'll change MD4, MD5, and SHA-1 to use `rotateLeft` in keeping with h

Re: RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations

2022-07-11 Thread Weijun Wang
On Mon, 11 Jul 2022 21:20:43 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-4887998 Two comments: 1. There are many unnecessary parenthesis, like `(32 - s)` or `(Integer... + 5)`. 2. Why choose `rotateRight` and not `rotateLeft`? https://en.wikipedia.org/wiki/SHA-1 uses "circula

RFR: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations

2022-07-11 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-4887998 - Commit messages: - Merge - first iteration Changes: https://git.openjdk.org/jdk/pull/9456/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9456&range=00 Issue: https://bugs.openjdk.org/browse/JDK-4887998 Stats: 31 lines in 5