Integrated: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

2025-05-14 Thread Fernando Guallini
On Tue, 4 Mar 2025 13:07:37 GMT, Fernando Guallini wrote: > The following tests are marked with @ignore (not running): > > - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting > the clientMode after the handshake has begun is not permitted, but this wa

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v4]

2025-04-25 Thread Fernando Guallini
On Fri, 21 Mar 2025 12:00:57 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted,

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

2025-04-05 Thread Fernando Guallini
On Thu, 20 Mar 2025 18:02:49 GMT, Artur Barashev wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> latch await > > test/jdk/sun/security/ssl/SSLSocketImpl/SetClien

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-27 Thread Fernando Guallini
On Tue, 18 Mar 2025 14:11:26 GMT, Mikhail Yankelevich wrote: >> 8351566: Consolidate third party artifacts used in tests > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: imports fix test/lib/jdk/test/lib/secu

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v4]

2025-03-22 Thread Fernando Guallini
l/NonAutoClose.java: This test should only run > in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. Included > additional refactoring to ensure test stability. > > Executed both tests 10K times, no test flakiness found Fernando Guallini has updated the pull request in

Re: RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-03-20 Thread Fernando Guallini
On Mon, 17 Mar 2025 18:19:46 GMT, Matthew Donovan wrote: >> The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to >> complete. The reason is that, in multiple scenarios, the server/client >> socket times out after 10 seconds waiting to receive a DatagramPacket that >> has

RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-03-20 Thread Fernando Guallini
The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to complete. The reason is that, in multiple scenarios, the server/client socket times out after 10 seconds waiting to receive a DatagramPacket that has been removed (to simulate a packet loss). After reducing the time out

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

2025-03-20 Thread Fernando Guallini
l/NonAutoClose.java: This test should only run > in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. Included > additional refactoring to ensure test stability. > > Executed both tests 10K times, no test flakiness found Fernando Guallini has updated the pull request in

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-20 Thread Fernando Guallini
On Tue, 18 Mar 2025 02:27:31 GMT, Artur Barashev wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> SSLContextTemplate and using asserts > > test/jdk/sun/security/ssl/SSLSocket

Re: RFR: 8350964: Add an ArtifactResolver.fetch(clazz) method [v2]

2025-03-12 Thread Fernando Guallini
On Tue, 11 Mar 2025 16:48:03 GMT, Matthew Donovan wrote: >> test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 90: >> >>> 88: generateInitialKeystores(opensslPath); >>> 89: testWithJavaCommands(); >>> 90: testWithOpensslCommands(opens

Re: RFR: 8350964: Add an ArtifactResolver.fetch(clazz) method

2025-03-11 Thread Fernando Guallini
On Tue, 11 Mar 2025 15:21:09 GMT, Matthew Donovan wrote: > In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to > consolidate duplicate code across tests. test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 90: > 88: generateInitialKeystores(openss

Integrated: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

2025-03-10 Thread Fernando Guallini
On Thu, 13 Feb 2025 12:44:21 GMT, Fernando Guallini wrote: > This updates the OpenSSL version that is used by test > `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS > version (3.0 series). > There are some differences between the 1.1.x and the current Ope

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v6]

2025-03-07 Thread Fernando Guallini
herefore adding the `-legacy` flag > when needed to enable it. Additionally, It is also required to specify the > path location of the legacy provider. > - Unlike the old version that throws an error if the MAC was absent from the > PKCS12, the 3.0 series shows a warning instead. Fe

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-06 Thread Fernando Guallini
l/NonAutoClose.java: This test should only run > in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. Included > additional refactoring to ensure test stability. > > Executed both tests 10K times, no test flakiness found Fernando Guallini has updated the pull request in

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-03-06 Thread Fernando Guallini
On Thu, 6 Mar 2025 12:54:03 GMT, Matthew Donovan wrote: >> Well, the test is also checking with java commands if openssl is available >> (line 75), then it makes sense to keep it when it is not available as it >> does not rely on Openssl. > > My concern is that a Pass result is ambiguous: we ma

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-06 Thread Fernando Guallini
On Wed, 5 Mar 2025 13:48:37 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> SSLContextTemplate and using asserts > > test/jdk/sun/security/ssl/SSLSocket

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-03-05 Thread Fernando Guallini
On Wed, 5 Mar 2025 19:45:14 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated wording of openssl version > > test/jdk/sun/security/pkcs12/KeytoolO

RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

2025-03-04 Thread Fernando Guallini
The following tests are marked with @ignore (not running): - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting the clientMode after the handshake has begun is not permitted, but this was failing intermittently due to a race condition, it was possible that SetClientMode wa

Integrated: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION

2025-02-21 Thread Fernando Guallini
On Fri, 21 Feb 2025 10:31:34 GMT, Fernando Guallini wrote: > The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses > CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic > links, but this was seen to crash the VM in Windows Server 2025.

Re: RFR: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION [v2]

2025-02-21 Thread Fernando Guallini
> The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses > CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic > links, but this was seen to crash the VM in Windows Server 2025. To ensure > test stability, it should hard copy the required file

RFR: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION

2025-02-21 Thread Fernando Guallini
The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic links, but this was seen to crash the VM in Windows Server 2025. To ensure test stability, it should hard copy the required files. - Co

Integrated: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

2025-02-20 Thread Fernando Guallini
On Mon, 20 Jan 2025 16:20:27 GMT, Fernando Guallini wrote: > The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not > modify the JDK home directory under test as that could impact the results of > other tests, or it could fail if the JDK home dir is read-only.

Integrated: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb

2025-02-20 Thread Fernando Guallini
On Mon, 5 Aug 2024 10:46:32 GMT, Fernando Guallini wrote: > There are 3 manual GSS-API/Kerberos tests that require a manual setup and > were added to the problem list years ago: > > - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and > server

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v4]

2025-02-19 Thread Fernando Guallini
On Tue, 18 Feb 2025 17:52:14 GMT, Rajan Halade wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v5]

2025-02-19 Thread Fernando Guallini
herefore adding the `-legacy` flag > when needed to enable it. Additionally, It is also required to specify the > path location of the legacy provider. > - Unlike the old version that throws an error if the MAC was absent from the > PKCS12, the 3.0 series shows a warning instead. Fe

Re: RFR: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

2025-02-17 Thread Fernando Guallini
On Mon, 20 Jan 2025 16:20:27 GMT, Fernando Guallini wrote: > The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not > modify the JDK home directory under test as that could impact the results of > other tests, or it could fail if the JDK home dir is read-only.

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v2]

2025-02-17 Thread Fernando Guallini
On Fri, 14 Feb 2025 17:20:11 GMT, Weijun Wang wrote: > Or "current version". I regret using this in my previous comment. I meant > "this one particular version" there. > > And yes, it will be clear if you mention the "current version as defined by > ...". Thanks, updated now - P

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v4]

2025-02-17 Thread Fernando Guallini
herefore adding the `-legacy` flag > when needed to enable it. Additionally, It is also required to specify the > path location of the legacy provider. > - Unlike the old version that throws an error if the MAC was absent from the > PKCS12, the 3.0 series shows a warning instead. Fe

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v2]

2025-02-14 Thread Fernando Guallini
herefore adding the `-legacy` flag > when needed to enable it. Additionally, It is also required to specify the > path location of the legacy provider. > - Unlike the old version that throws an error if the MAC was absent from the > PKCS12, the 3.0 series shows a warning instead. Fe

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

2025-02-14 Thread Fernando Guallini
On Fri, 14 Feb 2025 14:58:55 GMT, Weijun Wang wrote: > The "preferred version" sounds like user can choose one. I'd rather just say > "latest version". At least that is the latest our test has access to. Also, I > assume you will update to newer versions later and this test is not meant to > r

RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

2025-02-14 Thread Fernando Guallini
This updates the OpenSSL version that is used by test `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS version (3.0 series). There are some differences between the 1.1.x and the current OpenSSL version: - RC4 is not longer enabled by default, therefore adding the `-legacy`

Integrated: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2025-02-12 Thread Fernando Guallini
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini wrote: > The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** > relies on the `certutil.exe` tool to import and delete certificates from a > keystore. It was annotated with `@ignore` due to the uncer

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v3]

2025-02-11 Thread Fernando Guallini
On Fri, 7 Feb 2025 20:22:52 GMT, Rajan Halade wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into 8337723 >&g

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-11 Thread Fernando Guallini
On Tue, 11 Feb 2025 13:05:48 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and &

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-11 Thread Fernando Guallini
principal names, generates krb5.conf and > keytab files, and setup a JAAS login config file. > > I've enhanced SaslBasic to include additional wrap/unwrap checks with and > without a security layer. As a result, the 3 manual tests and their > associated files are now redundand

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v4]

2025-02-11 Thread Fernando Guallini
principal names, generates krb5.conf and > keytab files, and setup a JAAS login config file. > > I've enhanced SaslBasic to include additional wrap/unwrap checks with and > without a security layer. As a result, the 3 manual tests and their > associated files are now redundand

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v2]

2025-02-07 Thread Fernando Guallini
On Thu, 6 Feb 2025 18:11:30 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last

Integrated: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

2025-02-06 Thread Fernando Guallini
On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini wrote: > When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java > > > Two warning are shown: > > > test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] > possible 'th

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java

2025-02-06 Thread Fernando Guallini
On Thu, 6 Feb 2025 12:12:35 GMT, Mikhail Yankelevich wrote: > * ./util/Pem/encoding.sh is now a java test > * also added the validations for the test results, not only an error check test/jdk/sun/security/util/Pem/PemEncoding.java line 47: > 45: File.separator, > 46:

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore [v2]

2025-02-06 Thread Fernando Guallini
the test is executed. > > Rather than ignoring the test entirely, this PR updates the logic to throw a > `SkippedException` if the tool is not found, ensuring the test runs when > possible, and gracefully skipped otherwise. Fernando Guallini has updated the pull request incrementally wit

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2025-02-06 Thread Fernando Guallini
On Wed, 5 Feb 2025 22:45:36 GMT, Hai-May Chao wrote: > Nit: copyright update updated to 2025 now 👍 - PR Comment: https://git.openjdk.org/jdk/pull/21305#issuecomment-2639325902

Re: RFR: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

2025-02-06 Thread Fernando Guallini
On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini wrote: > When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java > > > Two warning are shown: > > > test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] > possible 'th

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2025-02-05 Thread Fernando Guallini
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini wrote: > The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** > relies on the `certutil.exe` tool to import and delete certificates from a > keystore. It was annotated with `@ignore` due to the uncer

RFR: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

2025-02-05 Thread Fernando Guallini
When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java Two warning are shown: test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] possible 'this' escape before subclass is fully initialized setHandler(handler); - setHandler is called in th

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v3]

2025-01-28 Thread Fernando Guallini
principal names, generates krb5.conf and > keytab files, and setup a JAAS login config file. > > I've enhanced SaslBasic to include additional wrap/unwrap checks with and > without a security layer. As a result, the 3 manual tests and their > associated files are now redundand

RFR: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

2025-01-20 Thread Fernando Guallini
The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not modify the JDK home directory under test as that could impact the results of other tests, or it could fail if the JDK home dir is read-only. This PR updates the test to - clone the tested JDK into the scratch directory

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2025-01-08 Thread Fernando Guallini
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini wrote: > The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** > relies on the `certutil.exe` tool to import and delete certificates from a > keystore. It was annotated with `@ignore` due to the uncer

[jdk24] Integrated: 8345414: Google CAInterop test failures

2024-12-06 Thread Fernando Guallini
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini wrote: > The following tests in CAInterop.java for Google test domain are currently > failing: > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > security/infra/jav

Re: [jdk24] RFR: 8345414: Google CAInterop test failures

2024-12-06 Thread Fernando Guallini
On Thu, 5 Dec 2024 18:12:56 GMT, Rajan Halade wrote: > LGTM. Can you target this fix to https://github.com/openjdk/jdk/tree/jdk24 > instead? Done - PR Comment: https://git.openjdk.org/jdk/pull/22542#issuecomment-2522683745

Re: RFR: 8345414: Google CAInterop test failures

2024-12-05 Thread Fernando Guallini
On Wed, 4 Dec 2024 14:44:22 GMT, SendaoYan wrote: > Hi, this test has been marked as manual test by > [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441). After this PR, > should we mark this test as automatic test. Hi, This test should remain manual, as it still depends on multiple ext

RFR: 8345414: Google CAInterop test failures

2024-12-04 Thread Fernando Guallini
The following tests in CAInterop.java for Google test domain are currently failing: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 security/infra/ja

Integrated: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

2024-11-06 Thread Fernando Guallini
On Wed, 23 Oct 2024 14:46:37 GMT, Fernando Guallini wrote: > The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends > sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider > configured with NSS config files located in the source tree directory > (

Integrated: 8342183: Update tests to use stronger algorithms and keys

2024-11-01 Thread Fernando Guallini
On Fri, 18 Oct 2024 08:33:36 GMT, Fernando Guallini wrote: > Several tests are identified to use weak/legacy algorithms. As these tests > purpose is not to exercise weak algorithms, these are updated in this PR to > use stronger algorithms. If the test uses a weak key, it is update

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v5]

2024-11-01 Thread Fernando Guallini
> Several tests are identified to use weak/legacy algorithms. As these tests > purpose is not to exercise weak algorithms, these are updated in this PR to > use stronger algorithms. If the test uses a weak key, it is updated as well. Fernando Guallini has updated the pull request incr

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v4]

2024-11-01 Thread Fernando Guallini
> Several tests are identified to use weak/legacy algorithms. As these tests > purpose is not to exercise weak algorithms, these are updated in this PR to > use stronger algorithms. If the test uses a weak key, it is updated as well. Fernando Guallini has updated the pull request w

Integrated: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex

2024-11-01 Thread Fernando Guallini
On Tue, 1 Oct 2024 08:51:29 GMT, Fernando Guallini wrote: > The test > **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may > fail with the following exception: > > > test PreserveRawManifestEntryAndDigest.testNameImmediatelyCo

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v7]

2024-10-31 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v2]

2024-10-31 Thread Fernando Guallini
On Wed, 30 Oct 2024 23:27:12 GMT, Anthony Scarpino wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add more algos to TestExplicitKeyLength.java > > test/jdk/com/su

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v3]

2024-10-31 Thread Fernando Guallini
> Several tests are identified to use weak/legacy algorithms. As these tests > purpose is not to exercise weak algorithms, these are updated in this PR to > use stronger algorithms. If the test uses a weak key, it is updated as well. Fernando Guallini has updated the pull request w

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v2]

2024-10-31 Thread Fernando Guallini
On Wed, 30 Oct 2024 23:35:19 GMT, Anthony Scarpino wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add more algos to TestExplicitKeyLength.java > > test/jdk/java/security/Sign

Integrated: 8342188: Update tests to use stronger key parameters and certificates

2024-10-31 Thread Fernando Guallini
On Thu, 17 Oct 2024 13:44:19 GMT, Fernando Guallini wrote: > Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a mod

Re: RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex

2024-10-31 Thread Fernando Guallini
On Thu, 31 Oct 2024 16:58:36 GMT, Sean Mullan wrote: > LGTM. Thanks for the review! - PR Comment: https://git.openjdk.org/jdk/pull/21280#issuecomment-2450494653

Integrated: 8342181: Update tests to use stronger Key and Salt size

2024-10-30 Thread Fernando Guallini
On Wed, 16 Oct 2024 12:34:32 GMT, Fernando Guallini wrote: > Several tests currently use weak key and salt sizes. Since the purpose of > these tests is not to evaluate weak keys, they can be updated to use stronger > keys length (2048-bits) and stronger Salt (16 bytes). This PR

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v9]

2024-10-30 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'master&#

Re: RFR: 8342183: Update tests to use stronger algorithms and keys [v2]

2024-10-29 Thread Fernando Guallini
> Several tests are identified to use weak/legacy algorithms. As these tests > purpose is not to exercise weak algorithms, these are updated in this PR to > use stronger algorithms. If the test uses a weak key, it is updated as well. Fernando Guallini has updated the pull request incr

Re: RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex

2024-10-29 Thread Fernando Guallini
On Tue, 1 Oct 2024 08:51:29 GMT, Fernando Guallini wrote: > The test > **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may > fail with the following exception: > > > test PreserveRawManifestEntryAndDigest.testNameImmediatelyCo

RFR: 8342183: Update tests to use stronger algorithms and keys

2024-10-29 Thread Fernando Guallini
Several tests are identified to use weak/legacy algorithms. As these tests purpose is not to exercise weak algorithms, these are updated in this PR to use stronger algorithms. If the test uses a weak key, it is updated as well. - Commit messages: - Merge branch 'master' into 834218

Re: RFR: 8342183: Update tests to use stronger algorithms and keys

2024-10-29 Thread Fernando Guallini
On Wed, 23 Oct 2024 19:37:50 GMT, Matthew Donovan wrote: >> Several tests are identified to use weak/legacy algorithms. As these tests >> purpose is not to exercise weak algorithms, these are updated in this PR to >> use stronger algorithms. If the test uses a weak key, it is updated as well. >

Re: RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree [v2]

2024-10-24 Thread Fernando Guallini
On Wed, 23 Oct 2024 19:50:19 GMT, Rajan Halade wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reusing Utils.CopyFiles > > test/jdk/sun/security/pkcs11/PKCS11Test.java lin

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v5]

2024-10-24 Thread Fernando Guallini
On Wed, 23 Oct 2024 19:43:33 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree [v2]

2024-10-24 Thread Fernando Guallini
onfig files to the Jtreg > scratch directory and configures the provider to use those files instead. Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: Reusing Utils.CopyFiles - Changes: - all: https://git.openjdk.org/j

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v8]

2024-10-24 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: simplified getTestKeySize - Ch

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v6]

2024-10-24 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

Re: RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

2024-10-24 Thread Fernando Guallini
On Wed, 23 Oct 2024 19:51:24 GMT, Rajan Halade wrote: >> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends >> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider >> configured with NSS config files located in the source tree directory >> (sun/security/pkcs11/

RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

2024-10-23 Thread Fernando Guallini
The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider configured with NSS config files located in the source tree directory (sun/security/pkcs11/nss) for the dependent tests to run properly. This test currently f

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v5]

2024-10-23 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v7]

2024-10-23 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the m

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v6]

2024-10-22 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: KeyToolTest.java will be updated in another PR -

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v4]

2024-10-22 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v3]

2024-10-21 Thread Fernando Guallini
On Mon, 21 Oct 2024 13:08:09 GMT, Weijun Wang wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Convert bits to bytes when necessary > > Have you timed the differences? I remember

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v4]

2024-10-21 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: Updated tests that were already using 2048 to use

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v3]

2024-10-21 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v5]

2024-10-21 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: Fix algo mistake in SignatureKeyInfo - Ch

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v3]

2024-10-21 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: Convert bits to bytes when necessary - Ch

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v2]

2024-10-21 Thread Fernando Guallini
r algorithms. > > There is no significant increase in tests run time, those still complete > consistently fast (few seconds). Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: Using SecurityUtils to define the

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v2]

2024-10-21 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 20

RFR: 8342188: Update tests to use stronger key parameters and certificates

2024-10-17 Thread Fernando Guallini
Several tests are identified to use weak key parameters (prime modulus, private/public values) and certs with weak keys. As these tests purpose is not to exercise weak keys, these are updated in this PR to use a modulus with 2048-bit, base 2 and certificates with key size 2048 - Co

RFR: 8342181: Update tests to use stronger Key and Salt size

2024-10-17 Thread Fernando Guallini
Several tests currently use weak key and salt sizes. If the purpose of the tests is not to evaluate weak keys, they should be updated to use stronger keys. This PR does not intend to update the tests to use stronger algorithms. There is no significant increase in tests run time, those still run

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v2]

2024-10-03 Thread Fernando Guallini
On Tue, 3 Sep 2024 07:57:47 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and &

RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2024-10-03 Thread Fernando Guallini
The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** relies on the `certutil.exe` tool to import and delete certificates from a keystore. It was annotated with `@ignore` due to the uncertainty of `certutil.exe` being available on the instance where the test is executed. Rath

RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex

2024-10-01 Thread Fernando Guallini
The test **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may fail with the following exception: test PreserveRawManifestEntryAndDigest.testNameImmediatelyContinued(): failure java.lang.AssertionError: "s k 300 Tue Jun 25 10:20:16 GMT+07:00 2024 META-INF/MANIFEST.MF" sho

Re: RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java [v3]

2024-09-26 Thread Fernando Guallini
his PR updates the maxOutputSize for the DTLS test directory, including > DTLSRehandshakeTest.java. Incrementing the maxOutputSize results in more > logs, with an approximate size increase of ~0.6MB when compressed. Fernando Guallini has updated the pull request incrementally with one addition

Integrated: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java

2024-09-26 Thread Fernando Guallini
On Tue, 3 Sep 2024 13:07:47 GMT, Fernando Guallini wrote: > The test javax/net/ssl/DTLS/DTLSRehandshakeTest.java runs multiple scenarios, > generating a large amount of logging as a result. Since Jtreg truncates the > output when it becomes too large, the logs are often not u

Integrated: 8339560: Unaddressed comments during code review of JDK-8337664

2024-09-26 Thread Fernando Guallini
On Wed, 11 Sep 2024 09:07:15 GMT, Fernando Guallini wrote: > During the code review of > [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several > non-critical comments were raised but not addressed due to time constraints. > This PR includes the following cha

Re: RFR: 8339560: Unaddressed comments during code review of JDK-8337664

2024-09-24 Thread Fernando Guallini
On Tue, 24 Sep 2024 15:57:28 GMT, Sean Mullan wrote: >> During the code review of >> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several >> non-critical comments were raised but not addressed due to time constraints. >> This PR includes the following changes: >> >> 1. Symantec

RFR: 8339560: Unaddressed comments during code review of JDK-8337664

2024-09-11 Thread Fernando Guallini
During the code review of [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several non-critical comments were raised but not addressed due to time constraints. This PR includes the following changes: 1. Symantec and Entrust tests now reuse common code. The Distrust.java class contai

Integrated: 8338395: Add test coverage for instantiating NativePRNG with SecureRandomParameters

2024-09-10 Thread Fernando Guallini
On Thu, 15 Aug 2024 09:29:00 GMT, Fernando Guallini wrote: > In order to improve performance when instantiating NativePRNG, a dummy > constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560 > which takes and ignores a `java.security.SecureRandomParameters`, th

Re: RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java

2024-09-05 Thread Fernando Guallini
On Thu, 5 Sep 2024 09:59:51 GMT, Jaikiran Pai wrote: > Hello Fernando, I'm not familiar with this test or the area, but if this > change is just to make available jtreg logs (in a separate file) to allow for > debugging a currently intermittent test failure, then there are ways to > change the

Re: RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java [v2]

2024-09-05 Thread Fernando Guallini
R updates the DTLS maxOutputSize for the test directory, including > DTLSRehandshakeTest.java. Incrementing the maxOutputSize results in more > logs, with an approximate size increase of 0.6MB when compressed. Fernando Guallini has updated the pull request with a new target base due to a

Integrated: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation

2024-09-05 Thread Fernando Guallini
On Tue, 27 Aug 2024 14:49:40 GMT, Fernando Guallini wrote: > The test sun/security/validator/samedn.sh failed once due to the following > reason: > > `Caused by: java.security.cert.CertificateNotYetValidException: NotBefore: > Tue Aug 06 14:41:13 GMT 2024` > > This t

  1   2   >