Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v2]

2025-02-11 Thread Martin Balao
On Wed, 22 Jan 2025 00:53:13 GMT, Anthony Scarpino wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Copyright update. >> >> Co-authored-by: Martin Balao Alonso >> Co-authored-by: Francisco Fe

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Martin Balao
On Tue, 11 Feb 2025 23:33:49 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Martin Balao
On Tue, 21 Jan 2025 23:54:02 GMT, Anthony Scarpino wrote: >> Just to add some more semantic value but we don't have a strong opinion, we >> can replace it with boolean if you want. > > Yes, please do that. Done. - PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussi

Re: RFR: 8349759: Fix CertificateBuilder and SimpleOCSPServer test utilities to support PQC algorithms

2025-02-11 Thread Jamil Nimeh
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote: > This fix makes some minor changes to the internals of the > `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break > when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS > works better now with thes

Re: RFR: 8349759: Fix CertificateBuilder and SimpleOCSPServer test utilities to support PQC algorithms

2025-02-11 Thread Bernd
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote: > This fix makes some minor changes to the internals of the > `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break > when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS > works better now with thes

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v3]

2025-02-11 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pull/23542

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v3]

2025-02-11 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 18:00:48 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > reworked Idea to check the availability of kerberos & code

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v3]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: reworked - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pull/23

RFR: 8349759: Fix CertificateBuilder and SimpleOCSPServer test utilities to support PQC algorithms

2025-02-11 Thread Jamil Nimeh
This fix makes some minor changes to the internals of the `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS works better now with these changes. I've also taken this opportunity to do some cleanup

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v3]

2025-02-11 Thread Leonid Mesnik
> The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. Leonid Mesnik has updated the pull request incrementally with two additional commits since the last revision: - Merge branch '8346050' of https://github.com/lmesnik/jdk into 8346050 - r

Re: RFR: 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test [v2]

2025-02-11 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 13:42:52 GMT, Sean Mullan wrote: > There's an extra '/' in the bug title, can you remove it? sure - PR Comment: https://git.openjdk.org/jdk/pull/23394#issuecomment-2650941072

Re: RFR: 8349151: Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java test [v2]

2025-02-11 Thread Sean Mullan
On Mon, 3 Feb 2025 19:12:30 GMT, Mikhail Yankelevich wrote: >> Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java >> test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > cleanup There's an e

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 11:29:59 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup test/jdk/sun/security/krb5/Krb5NameEquals.ja

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 11:29:59 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor cleanup test/jdk/sun/security/krb5/Krb5NameEquals.ja

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Weijun Wang
On Tue, 11 Feb 2025 13:22:08 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor cleanup > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 92: > >> 90: final var

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v3]

2025-02-11 Thread Fernando Guallini
On Fri, 7 Feb 2025 20:22:52 GMT, Rajan Halade wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into 8337723 >> - Merge branch 'master' into 8337723 >> - ref

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-11 Thread Fernando Guallini
On Tue, 11 Feb 2025 13:05:48 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and >> server have completed the

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-11 Thread Fernando Guallini
> There are 3 manual GSS-API/Kerberos tests that require a manual setup and > were added to the problem list years ago: > > - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and > server have completed the authentication process. > - com/sun/security/sasl/gsskerb/**NoSecur

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v4]

2025-02-11 Thread Fernando Guallini
> There are 3 manual GSS-API/Kerberos tests that require a manual setup and > were added to the problem list years ago: > > - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and > server have completed the authentication process. > - com/sun/security/sasl/gsskerb/**NoSecur

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Mikhail Yankelevich
On Mon, 10 Feb 2025 18:23:35 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor cleanup > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 94: > >> 92: >> 93:

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

2025-02-11 Thread Mikhail Yankelevich
> Refactored the runNameEquals.sh to java test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/23542/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-11 Thread Mikhail Yankelevich
On Mon, 10 Feb 2025 18:32:21 GMT, Matthew Donovan wrote: >> Refactored the runNameEquals.sh to java test > > test/jdk/sun/security/krb5/Krb5NameEquals.java line 145: > >> 143: GSSName.NT_HOSTBASED_SERVICE, MECH); >> 144: >> 145: if (!name1.equals(name1) || !name1

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-11 Thread Bhavana Kilambi
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in