Re: RFR: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version [v2]

2025-01-30 Thread Weijun Wang
On Thu, 30 Jan 2025 18:36:44 GMT, Rajan Halade wrote: >> This fix updates compatibility tests with verification against ACVP 1.1.0.38 >> data. The new data files in v1.1.0.38 are significantly larger in file size >> so they are moved to artifactory or are to be provided for local run. Refer >>

Re: RFR: 8347123: Add missing @serial tags to other modules [v2]

2025-01-30 Thread Nizar Benalla
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc >> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the >> javadoc `-serialwarn` option in the JDK doc build, which has been disabled >> since

RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified.

2025-01-30 Thread Bradford Wetmore
Update and clarify the sample code. Docs only, no additional testing other than verifying javadoc is correctly output. - Commit messages: - 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified Changes: https://git.openjdk.org/jdk/pull/23379/files Web

RFR: 8347938: Switch to latest ML-KEM private key encoding

2025-01-30 Thread Weijun Wang
The private key encoding formats of ML-KEM and ML-DSA are updated to match the latest IERTF drafts at: https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-06 and https://datatracker.ietf.org/doc/html/draft-ietf-lamps-kyber-certificates-07. Most importantly, the seed u

Re: Encoding of ML-DSA private keys

2025-01-30 Thread Sean Mullan
Hi Chris, Yes we are aware of the issue and there are two open issues tracking this, one for ML-KEM and one for ML-DSA: https://bugs.openjdk.org/browse/JDK-8347938 https://bugs.openjdk.org/browse/JDK-8347941 Stay tuned for further progress on resolving these issues. --Sean On 1/30/25 12:59

Re: RFR: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version [v2]

2025-01-30 Thread Rajan Halade
> This fix updates compatibility tests with verification against ACVP 1.1.0.38 > data. The new data files in v1.1.0.38 are significantly larger in file size > so they are moved to artifactory or are to be provided for local run. Refer > to `Launcher.java` for more details on this. Rajan Halade

Encoding of ML-DSA private keys

2025-01-30 Thread Chris Vest
Hi, I downloaded JDK 24 EA to play with the new ML-DSA features, and noticed that the `PrivateKey.getEncoded()` produces the expanded-form private key format. However, the industry is aligning behind the seed-form. [1] For instance, BoringSSL removed[2] support for parsing expanded-form private ke

Re: RFR: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version

2025-01-30 Thread Weijun Wang
On Thu, 30 Jan 2025 15:16:16 GMT, Rajan Halade wrote: > This fix updates compatibility tests with verification against ACVP 1.1.0.38 > data. The new data files in v1.1.0.38 are significantly larger in file size > so they are moved to artifactory or are to be provided for local run. Refer > to

Re: RFR: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version

2025-01-30 Thread Weijun Wang
On Thu, 30 Jan 2025 15:16:16 GMT, Rajan Halade wrote: > This fix updates compatibility tests with verification against ACVP 1.1.0.38 > data. The new data files in v1.1.0.38 are significantly larger in file size > so they are moved to artifactory or are to be provided for local run. Refer > to

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v2]

2025-01-30 Thread Andrew Dinn
On Thu, 30 Jan 2025 16:14:27 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v2]

2025-01-30 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

RFR: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version

2025-01-30 Thread Rajan Halade
This fix updates compatibility tests with verification against ACVP 1.1.0.38 data. - Commit messages: - minor cleanup - fix for windows failure - 8349017: Update ML tests to verify against ACVP 1.1.0.38 version Changes: https://git.openjdk.org/jdk/pull/23370/files Webrev: https

Re: RFR: 8261513: Various BasicConstraintsExtension issues

2025-01-30 Thread Sean Mullan
On Wed, 17 Jul 2024 20:07:36 GMT, Ben Perez wrote: > 8261513: Various BasicConstraintsExtension issues src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java line 1: > 1: /* On line 143, we should throw an `IOException` if the decoded pathLenConstraint field is < 0. Thi