On Thu, 30 Jan 2025 15:16:16 GMT, Rajan Halade <rhal...@openjdk.org> wrote:

> This fix updates compatibility tests with verification against ACVP 1.1.0.38 
> data. The new data files in v1.1.0.38 are significantly larger in file size 
> so they are moved to artifactory or are to be provided for local run. Refer 
> to `Launcher.java` for more details on this.

test/jdk/sun/security/provider/acvp/Launcher.java line 95:

> 93:             
> "gen-val/json-files/ML-KEM-keyGen-FIPS203/internalProjection.json"
> 94:     };
> 95: 

One more comment, since we only run on `TEST_FILES`, we should require all of 
them to succeed. I suggest a real exception to be thrown when `invalidTest` or 
`unsupportedTest` is not zero.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23370#discussion_r1936001283

Reply via email to