Integrated: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
On Sat, 12 Oct 2024 01:59:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java. This pull request has now been integrated. Changeset: 2e1c1936 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/2e1c1936e1

Re: RFR: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
On Sat, 12 Oct 2024 02:04:56 GMT, Jaikiran Pai wrote: >> A trivial fix to ProblemList >> sun/security/tools/keytool/GenKeyPairSigner.java. > > Looks OK to me. @jaikiran - Thanks for the fast review! Especially for a Friday night... I'm holding off on integrating until I see if it repros in the

Re: RFR: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Jaikiran Pai
On Sat, 12 Oct 2024 01:59:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java. Looks OK to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21481#pullrequestreview-2363716720

RFR: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java. - Commit messages: - 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java Changes: https://git.openjdk.org/jdk/pull/21481/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21481&ra

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v5]

2024-10-11 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v4]

2024-10-11 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request with a new target base due to a merge or a rebase. The pull reque

Re: RFR: 8339009: ML-KEM Quantum-Resistant Key Encapsulation Mechanism [v2]

2024-10-11 Thread Ben Perez
> Java implementation of ML-KEM, the [FIPS > 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. > Depends on https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11

Integrated: 8340327: A common framework to support public key algorithms with standard parameter sets

2024-10-11 Thread Weijun Wang
On Tue, 24 Sep 2024 16:34:25 GMT, Weijun Wang wrote: > To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. This pul

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v16]

2024-10-11 Thread Anthony Scarpino
On Fri, 11 Oct 2024 21:16:55 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v16]

2024-10-11 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v15]

2024-10-11 Thread Valerie Peng
On Fri, 11 Oct 2024 19:52:32 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v15]

2024-10-11 Thread Sean Mullan
On Fri, 11 Oct 2024 19:52:32 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v15]

2024-10-11 Thread Anthony Scarpino
On Fri, 11 Oct 2024 19:52:32 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

RFR: 8339009: ML-KEM Quantum-Resistant Key Encapsulation Mechanism

2024-10-11 Thread Ben Perez
Java implementation of ML-KEM, the [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. Depends on https://github.com/openjdk/jdk/pull/21167 - Commit messages: - Added ML_KEM_Provider - Added SHA3Parallel - Refactored ML_KEM to separate core protocol fro

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-11 Thread Weijun Wang
On Tue, 8 Oct 2024 20:17:53 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/provider/NamedSignature.java line >> 196: >> >>> 194: /// This object will be passed into the [#implVerify] method along >>> with the raw key. >>> 195: /// >>> 196: /// The default imple

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v14]

2024-10-11 Thread Weijun Wang
On Fri, 11 Oct 2024 18:50:39 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> describe a limitation of this framework > > src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v15]

2024-10-11 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v14]

2024-10-11 Thread Sean Mullan
On Fri, 11 Oct 2024 16:34:51 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v20]

2024-10-11 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v56]

2024-10-11 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v14]

2024-10-11 Thread Anthony Scarpino
On Fri, 11 Oct 2024 16:34:51 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > W

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v14]

2024-10-11 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v55]

2024-10-11 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-11 Thread Ferenc Rakoczi
On Thu, 10 Oct 2024 15:43:18 GMT, Weijun Wang wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed internal keyGen/sign/verify functions to be same as spec > > src/java.base/share/classes/sun/security/provider/ML_D

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-11 Thread Ferenc Rakoczi
On Thu, 10 Oct 2024 15:42:21 GMT, Weijun Wang wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed internal keyGen/sign/verify functions to be same as spec > > src/java.base/share/classes/sun/security/provider/ML_D

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-11 Thread Ferenc Rakoczi
On Thu, 10 Oct 2024 15:40:48 GMT, Weijun Wang wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed internal keyGen/sign/verify functions to be same as spec > > src/java.base/share/classes/sun/security/provider/ML_D

Re: RFR: 8329251: Print custom truststore/ keystore name [v4]

2024-10-11 Thread Sean Coffey
On Mon, 7 Oct 2024 12:42:00 GMT, Prasadrao Koppula wrote: >> Using SharedSecrets, I attempted to expose FileInputStream::path >> information. After implementing the fix, I validated the startup performance >> tests. Observed no consistent pattern of performance drops or gains, can >> disregard