On Wed, 11 Sep 2024 22:49:12 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
>> line 143:
>>
>>> 141: throws InvalidAlgorithmParameterException {
>>> 142: List ikms, salts;
>>> 143: byte[] inputKeyMaterial, salt, pse
On Tue, 10 Sep 2024 09:46:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which replaces the usages of
> `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
> outdat
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Tue, 25 Jun 2024 01:14:05 GMT, Alexey Bakhtin wrote:
> Please review a proposal to verify Trust Settings for Keychain key entries.
>
> Keychain-related Jtreg tests passed.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19872
On Wed, 17 Jul 2024 20:07:36 GMT, Ben Perez wrote:
> 8261513: Various BasicConstraintsExtension issues
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20224
On Wed, 11 Sep 2024 20:58:01 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> batch of review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 341:
>
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
>
> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
Kevin Driver
On Mon, 9 Sep 2024 20:50:47 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/java/security/KDFParameters.java line 39:
>
>>
On Wed, 11 Sep 2024 20:09:20 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> batch of review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 55:
>
>
On Sun, 8 Sep 2024 16:36:03 GMT, Alan Bateman wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/javax/crypto/KDF.java line 53:
>
>> 51: *
>
On Mon, 9 Sep 2024 21:08:34 GMT, Sean Mullan wrote:
>> Addressed in:
>> https://github.com/openjdk/jdk/pull/20301/commits/59b1743fd225ff34e6bcce055fd47a887ed22a08.
>> Please indicate if resolved.
>
> The first comment above is not resolved. You still have the repeated sentence.
@seanjmullan: T
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
>
> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
Kevin Driver
On Wed, 11 Sep 2024 20:58:01 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> batch of review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 341:
>
On Wed, 11 Sep 2024 20:31:13 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> batch of review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 299:
>
On Wed, 11 Sep 2024 20:16:40 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> batch of review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 148:
>
On Tue, 10 Sep 2024 15:25:53 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/javax/crypto/KDF.java line 349:
>
>> 347:
On Tue, 10 Sep 2024 20:13:08 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>>
>> Work was begun in [another P
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 11 Sep 2024 13:26:27 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Sean
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 290:
>
>> 288:
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
another comment from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk
During the code review of
[JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
non-critical comments were raised but not addressed due to time constraints.
This PR includes the following changes:
1. Symantec and Entrust tests now reuse common code. The Distrust.java class
contai
On Tue, 13 Aug 2024 15:30:09 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> comment from Sean
src/java.base/share/classes/sun/security/x509/X509CRLImpl
On Tue, 13 Aug 2024 20:49:35 GMT, Rajan Halade wrote:
> Updated VerifyCACerts test to check if BasicConstraints lists "CA:true" and
> KeyUsage, if included, asserts the keyCertSign bit.
test/jdk/sun/security/lib/cacerts/VerifyCACerts.java line 405:
> 403: boolean[] keyUsageBits = c
On Mon, 9 Sep 2024 12:57:17 GMT, Maurizio Cimadamore
wrote:
> The new test added by https://github.com/openjdk/jdk/pull/20854 fails
> spuriously.
> While JNI lookup is now moved into the static initializer of the
> `MappedMemoryUtils` class, this class might only get initialized while in the
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 11 Sep 2024 09:03:58 GMT, Alexey Ivanov wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update JImageToolTest too
>
> test/jdk/java/beans/Introspector/Test5102804.java line 28:
>
>> 26: * @bug 5102804
>>
> Can I please get a review of this trivial change which replaces the usages of
> `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
> outdated and support for them will soon be deprecated and remo
On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
29 matches
Mail list logo
