Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Sibabrata Sahoo
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Daniel Jeliński
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: [jdk23] RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-25 Thread Tobias Hartmann
On Tue, 25 Jun 2024 23:50:20 GMT, Volodymyr Paprotski wrote: > Hi all, > > This pull request contains a backport of commit > [f101e153](https://github.com/openjdk/jdk/commit/f101e153cee68750fcf1f12da10e29806875b522) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The com

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Sibabrata Sahoo
On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of th

Re: [jdk23] RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-25 Thread Aksh Desai
On Tue, 25 Jun 2024 23:50:20 GMT, Volodymyr Paprotski wrote: > Hi all, > > This pull request contains a backport of commit > [f101e153](https://github.com/openjdk/jdk/commit/f101e153cee68750fcf1f12da10e29806875b522) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The com

[jdk23] RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-25 Thread Volodymyr Paprotski
Hi all, This pull request contains a backport of commit [f101e153](https://github.com/openjdk/jdk/commit/f101e153cee68750fcf1f12da10e29806875b522) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Thanks! - Commit messages: - Backport f101e153cee68750fcf1f12da10e298

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation [v2]

2024-06-25 Thread Anthony Scarpino
> Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the > NewSessionTicket change in > [JDK-8328608](https://bugs.open

Integrated: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-25 Thread Volodymyr Paprotski
On Fri, 14 Jun 2024 20:23:04 GMT, Volodymyr Paprotski wrote: > This fix recovers XDH performance but removes some of the P256 gains > (~-8-14%). Still faster, but not as much. > > The fix is to undo 'int' return type on mult()/square(), which allowed to > return partially reduced result (e.g.

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-25 Thread Volodymyr Paprotski
On Tue, 25 Jun 2024 17:31:09 GMT, Ferenc Rakoczi wrote: >> Hi @vpaprotsk, >> @ferakocz is going to take a look at the change. When he says it's ok, I'll >> approve the PR. > > @ascarpino please approve this change. Thanks @ferakocz @ascarpino - PR Comment: https://git.openjdk.or

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-25 Thread Anthony Scarpino
On Mon, 17 Jun 2024 16:38:55 GMT, Volodymyr Paprotski wrote: >> This fix recovers XDH performance but removes some of the P256 gains >> (~-8-14%). Still faster, but not as much. >> >> The fix is to undo 'int' return type on mult()/square(), which allowed to >> return partially reduced result (

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Anthony Scarpino
On Tue, 25 Jun 2024 19:44:00 GMT, Daniel Jeliński wrote: >> I tried this and it caused a lockup in one of the tests. I see why your >> think this is the right change, but it isn't proving out in the testing > > That's very interesting! Which test was it? Was it with or without #19465? I do run

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Tue, 25 Jun 2024 18:26:40 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java line >> 171: >> >>> 169: for (int limit = (offset + length); offset < limit;) { >>> 170: >>> 171: int remains = (limit - offset) + (

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Anthony Scarpino
On Tue, 25 Jun 2024 08:14:10 GMT, Daniel Jeliński wrote: >> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of the

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-25 Thread Andrew John Hughes
On Fri, 21 Jun 2024 16:11:34 GMT, Rajan Halade wrote: >> Updated all the tests that depend on external infrastructure services as >> manual. These tests may fail with external reasons, for instance - change in >> CA test portal, certificate status updates, or network issues. > > Rajan Halade ha

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-25 Thread Ferenc Rakoczi
On Mon, 17 Jun 2024 16:38:55 GMT, Volodymyr Paprotski wrote: >> This fix recovers XDH performance but removes some of the P256 gains >> (~-8-14%). Still faster, but not as much. >> >> The fix is to undo 'int' return type on mult()/square(), which allowed to >> return partially reduced result (

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-25 Thread Ferenc Rakoczi
On Mon, 17 Jun 2024 19:21:37 GMT, Anthony Scarpino wrote: >>> What causes regression in P256 "(~-8-14%)"? From what I see, you >>> re-arranged code to not execute some code ("reducePositive()") when it is >>> not needed. How this affects P256? >> >> Actually, the other way around; reducePosit

Re: RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-25 Thread Rajan Halade
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote: > Hi, > > I need a review for this simple change to fix a threading problem with the > test. The server thread was not completing before the check occurred on the > main thread. The failure showed up in windows and macos, but not linux.

Integrated: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature

2024-06-25 Thread Sean Mullan
On Fri, 14 Jun 2024 15:32:15 GMT, Sean Mullan wrote: > Added links from the `PSSParameterSpec` API to new section in Standard > Algorithm Names specification for PSSParameterSpec (changes for that are in > closed repo). Also made a couple of links to the Standard Algorithm Names > specificatio

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 16:03:43 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino wrote: > Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the >

Re: RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino wrote: > Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the >