Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v8]

2024-06-06 Thread Valerie Peng
On Fri, 7 Jun 2024 01:14:39 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose an implementation to support AES CBC with Ciphertext >> Stealing (CTS) in SunPKCS11, according to what has been specified in >> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Valerie Peng
On Thu, 6 Jun 2024 22:21:57 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java >> line 1169: >> >>> 1167: } >>> 1168: if (ciphertextArr != null) { >>> 1169: ciphertextBuf = ByteBuffer.wrap(ciphertextArr); >> >> Can w

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Valerie Peng
On Fri, 7 Jun 2024 01:08:40 GMT, Martin Balao wrote: >> test/jdk/sun/security/pkcs11/Cipher/TestCipherTextStealingMultipart.java >> line 139: >> >>> 137: byte [] outArray = new byte[cipher.getOutputSize(0) + outOfs]; >>> 138: cipher.doFinal(outArray, outOfs); >>> 139: ac

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-06 Thread Rajan Halade
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v8]

2024-06-06 Thread Francisco Ferrari Bihurriet
> Hi, > > I would like to propose an implementation to support AES CBC with Ciphertext > Stealing (CTS) in SunPKCS11, according to what has been specified in > [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843). > > What follows are implementation notes that describe the most releva

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Martin Balao
On Fri, 7 Jun 2024 00:39:50 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Apply code-review suggestion >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Martin Ba

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Valerie Peng
On Wed, 5 Jun 2024 20:19:25 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose an implementation to support AES CBC with Ciphertext >> Stealing (CTS) in SunPKCS11, according to what has been specified in >> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v7]

2024-06-06 Thread Francisco Ferrari Bihurriet
> Hi, > > I would like to propose an implementation to support AES CBC with Ciphertext > Stealing (CTS) in SunPKCS11, according to what has been specified in > [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843). > > What follows are implementation notes that describe the most releva

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Martin Balao
On Thu, 6 Jun 2024 22:22:06 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Apply code-review suggestion >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Martin Ba

Re: [External] : Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-06-06 Thread Jonathan Gibbons
On 6/5/24 2:51 AM, Osipov, Michael wrote: On 2024-05-31 21:38, Jonathan Gibbons wrote: Michael, There is no `element-list` file for any version of JDK before JDK 9. Before JDK 9, the appropriate information was in the `package-list` file. In JDK 9, with the introduction of modules, the format

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Martin Balao
On Thu, 6 Jun 2024 21:18:04 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Apply code-review suggestion >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Martin Ba

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Valerie Peng
On Wed, 5 Jun 2024 20:19:25 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose an implementation to support AES CBC with Ciphertext >> Stealing (CTS) in SunPKCS11, according to what has been specified in >> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Valerie Peng
On Wed, 5 Jun 2024 20:19:25 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose an implementation to support AES CBC with Ciphertext >> Stealing (CTS) in SunPKCS11, according to what has been specified in >> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

2024-06-06 Thread Valerie Peng
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-864 src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrap.java line 121: > 119: @Override > 120: int encrypt(byte[] pt, int ptOfs, int ptLen, byte[] ct, int ctOfs) { > 121: thr

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

2024-06-06 Thread Francisco Ferrari Bihurriet
On Wed, 5 Jun 2024 23:08:57 GMT, Valerie Peng wrote: > The CSR is quite lengthy and some wordings may be more suitable for another > section, so I made some adjustments. In addition, I made some minor wording > changes to the specification section to be more align with the existing > guide. Co

Re: RFR: 8333477: Delete extra empty spaces in Makefiles

2024-06-06 Thread Chen Liang
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. Changes requested by liach (Author). test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1: > 1:

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-06 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

Re: RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-06 Thread Mark Powers
On Wed, 5 Jun 2024 23:48:56 GMT, Anthony Scarpino wrote: >> test/jdk/javax/net/ssl/templates/TLSBase.java line 101: >> >>> 99: if (!empty) { >>> 100: fis = new FileInputStream(System.getProperty("test.src", >>> "./") + >>> 101: "/" + pathToStores + "/" + keyS

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v3]

2024-06-06 Thread Matthew Donovan
On Thu, 6 Jun 2024 13:13:00 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v3]

2024-06-06 Thread Fernando Guallini
> As highlighted in the bug description, The test > **security/Security/SynchronizedAccess.java** have some issues: > > 1. it needs to implement the sigalg, otherwise it throws > java.security.NoSuchAlgorithmException . Even though it does not fail as it > catches the exception, it never reache

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]

2024-06-06 Thread Fernando Guallini
On Thu, 6 Jun 2024 11:25:39 GMT, Matthew Donovan wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]

2024-06-06 Thread Matthew Donovan
On Mon, 3 Jun 2024 09:54:16 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug