Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v7]

2023-10-19 Thread Chen Liang
On Wed, 18 Oct 2023 18:13:38 GMT, Glavo wrote: >> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. >> >> Reasons: >> >> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, >> creating a new shortcut can make writing shorter; >> * Since all possible values

RE: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809

2023-10-19 Thread Nico Williams
Also, a colleague informs me that 17.0.5 (as packaged by Debian) w/o `-Djdk.spnego.cache=false` doesn't exhibit the double-free/use-after-free crashes (as expected), but: > I do see some "Authentication failure" / and "java.lang.NullPointerException: > Cannot invoke "sun.net.www.protocol.http.N

Re: RFR: 8318486: Rename JavaLangAccess.xxNoRepl to xxReportError [v2]

2023-10-19 Thread Chen Liang
On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang wrote: >> Please review a patch that renames `JavaLangAccess::xxNoRepl` to >> `xxReportError` to explicitly indicate these APIs report encoding errors. >> >> The old "NoRepl" suffix presumably means "No Replacement", but it has been >> misunderstood

Re: RFR: 8318486: Rename JavaLangAccess.xxNoRepl to xxReportError [v2]

2023-10-19 Thread Chen Liang
> Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and > `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to > accurately describe these APIs. This also renames other associated methods. > > NoRepl means "no replication", which is not what these

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-19 Thread Weijun Wang
On Fri, 20 Oct 2023 00:12:25 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> inline some throw statements, remove duplicated whitespaces > > src/java.base/share/classes/sun/security/tools/keytool/M

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-19 Thread Valerie Peng
On Mon, 16 Oct 2023 16:23:13 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

RE: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809

2023-10-19 Thread Nico Williams
I failed to include the reproducer, which is: import java.net.*; public class Test { public static void main(String[] args) { for (int i = 0; i < 500; i++) { new Thread(() -> { try { URL url = new URL(args[0]);

HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809

2023-10-19 Thread Nico Williams
# Crashes We recently upgrade to OpenJDK 17.0.8.1 and started observing crashes resulting from double-frees via `gss_delete_sec_context()`. Adding `-Djdk.spnego.cache=false` to our java invocations stops the crashes. We believe this is due to a race condition that has long been in `HttpURLConne

RFR: 8317373: Add Telia Root CA v2

2023-10-19 Thread Rajan Halade
This PR is to add two new TLS root certificates from Telia. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process. The release-note is at [JDK-8318472](https://bugs.openjdk.org/browse/JDK-8318472) - Commit messages: - 8317373: A

Integrated: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions

2023-10-19 Thread Smita Kamath
On Thu, 24 Aug 2023 06:12:29 GMT, Smita Kamath wrote: > Hi All, > I would like to submit AES-GCM optimization for x86_64 architectures using > AVX2 instructions. This optimization interleaves AES and GHASH operations. > > Below are the performance numbers on my desktop system with -XX:UseAVX=2

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v8]

2023-10-19 Thread Smita Kamath
On Thu, 19 Oct 2023 14:32:20 GMT, Tobias Hartmann wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated comments, removed unused labels > > All tests passed. @TobiHartmann Thank you for running the tests. -

Re: RFR: 8315097: Rename createJavaProcessBuilder [v5]

2023-10-19 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi

Re: RFR: 8315097: Rename createJavaProcessBuilder [v4]

2023-10-19 Thread Leo Korinth
On Tue, 17 Oct 2023 12:29:46 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v8]

2023-10-19 Thread Tobias Hartmann
On Wed, 11 Oct 2023 22:05:08 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

Re: RFR: 8318240: [AIX] Cleaners.java test failure

2023-10-19 Thread Andreas Steiner
On Tue, 17 Oct 2023 07:31:07 GMT, Varada M wrote: > When the test sets the sun.security.jgss.native and > sun.security.nativegss.debug as true, the test fails on AIX due to missing > Kerberos GSS API dynamic library` libgssapi_krb5.so` > > JBS Issue : [JDK-8318240](https://bugs.openjdk.org/br

Re: RFR: 8318240: [AIX] Cleaners.java test failure

2023-10-19 Thread Matthias Baesken
On Tue, 17 Oct 2023 07:31:07 GMT, Varada M wrote: > When the test sets the sun.security.jgss.native and > sun.security.nativegss.debug as true, the test fails on AIX due to missing > Kerberos GSS API dynamic library` libgssapi_krb5.so` > > JBS Issue : [JDK-8318240](https://bugs.openjdk.org/br

Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
On Thu, 19 Oct 2023 07:25:38 GMT, Alan Bateman wrote: > I assume it's "no replace", meaning it reports the error rather than use the > coder's replacement value. This revelation is too important; I might have to reevaluate my choices, for many contributors have assumed that `NoRepl` was intend

Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote: > Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and > `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to > accurately describe these APIs. This also renames other associated methods. > > N

Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Alan Bateman
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote: > NoRepl means "no replication", which is not what these APIs are for. I assume it's "no replace", meaning it reports the error rather than use the coder's replacement value. I agree it could be renamed but I think look at CodingErrorAction

RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to accurately describe these APIs. This also renames other associated methods. NoRepl means "no replication", which is not what these APIs are f