On Mon, 16 Oct 2023 16:23:13 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Remove most `System.exit()` calls in various security tools and only leave
>> one in the `main` method. This paves the way to convert them to JSR 199
>> tools.
>>
>> Note: before this change, the behavior of a successful `main()` method
>> execution is not consistent. Sometimes the method returns silently,
>> sometimes a `System.exit(0)` is called somewhere. After this change, the
>> method always returns silently. This makes sure that existing programs that
>> calls the `main` method directly will continue and does not exit the VM.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inline some throw statements, remove duplicated whitespaces
src/java.base/share/classes/sun/security/tools/keytool/Main.java line 425:
> 423: }
> 424:
> 425: public int run(String[] args, PrintStream out) throws Exception {
Is this run() method used outside of this class, and thus the scope change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1366269790
