> Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and > `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to > accurately describe these APIs. This also renames other associated methods. > > NoRepl means "no replication", which is not what these APIs are for. They > instead expose the fail-fast construction fast-path in String, allowing > `ZipCoder` to quickly throw encoding exceptions wrapped in > `IllegalArgumentException` without going through decoders and encoders. > > In addition, there is already `newStringNoRepl` and `getBytesNoRepl` in > `JavaLangAccess` that actually avoids copying arrays for trusted usages, > further increasing the confusion. Given these internal APIs are frequently > used in recent contributions around improving string performance, I believe a > rename of these APIs is necessary. > > Pinging @cl4es for a review since you use this particular API the most often.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision: NoRepl -> ReportError ------------- Changes: - all: https://git.openjdk.org/jdk/pull/16260/files - new: https://git.openjdk.org/jdk/pull/16260/files/1af50e96..3a94643c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16260&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16260&range=00-01 Stats: 240 lines in 10 files changed: 95 ins; 96 del; 49 mod Patch: https://git.openjdk.org/jdk/pull/16260.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16260/head:pull/16260 PR: https://git.openjdk.org/jdk/pull/16260
