On Wed, 5 Jul 2023 20:25:26 GMT, Kevin Driver wrote:
> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
> `ClientCertificateType`; rather than throwing the `NPE`, we now throw an
> `IllegalArgumentException`. This does not seem to be a scenario where
> recovery is poss
On Wed, 5 Jul 2023 20:52:56 GMT, Pavel Rappo wrote:
>> Are you sure? I just checked lines 91-92 and I'd say the change looks
>> correct.
>
>> The original `<=` was correct, the number of bits in the input array must be
>> less than the requested length of the BitArray. The constructors also
>>
On Wed, 5 Jul 2023 19:35:23 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/util/BitArray.java line 72:
>>
>>> 70: * specified byte array. The most significant bit of {@code a[0]}
>>> gets
>>> 71: * index zero in the BitArray. The array must be large enough to
On Wed, 5 Jul 2023 18:04:01 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Mon, 12 Jun 2023 18:15:48 GMT, Rajan Halade wrote:
> This fix converted shell test to java code. Following are the updates done to
> the original shell test logic:
>
> - Test is updated to be a manual test as it is rather difficult/impossible to
> have it run in virtualized environment wher
On Wed, 5 Jul 2023 18:11:41 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Wed, 5 Jul 2023 14:52:22 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 27 Jun 2023 18:37:57 GMT, Rajan Halade wrote:
> This test update should be included in JDK 21 LTS release.
This pull request has now been integrated.
Changeset: 604e03de
Author:Rajan Halade
URL:
https://git.openjdk.org/jdk21/commit/604e03de78a0ed4f687ee2cd95b0d409b4c3736a
St
On Wed, 5 Jul 2023 14:52:22 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Wed, 5 Jul 2023 12:16:32 GMT, Daniel Jeliński wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add even more cases and tidy up
>
> src/java.base/share/classes/sun/security/provider/PolicyParser.java line 1133:
>
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
On Wed, 5 Jul 2023 14:39:44 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/security/spec/ECFieldF2m.java line 235:
>>
>>> 233: public int hashCode() {
>>> 234: int value = m << 5;
>>> 235: // consider simplifying using Objects.hashCode(rp) after
>>> JDK-8015417
On Wed, 5 Jul 2023 12:31:09 GMT, Daniel Jeliński wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add even more cases and tidy up
>
> src/java.base/share/classes/java/security/spec/ECFieldF2m.java line 235:
>
>> 233
On Tue, 4 Jul 2023 16:27:05 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 4 Jul 2023 16:27:05 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 4 Jul 2023 16:27:05 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
16 matches
Mail list logo
