Re: RFR: 8305091: Change ChaCha20 cipher init behavior to match AES-GCM

2023-05-19 Thread Anthony Scarpino
On Tue, 11 Apr 2023 17:26:25 GMT, Jamil Nimeh wrote: > This fixes an issue where the key/nonce reuse policy for SunJCE ChaCha20 and > ChaCha20-Poly1305 was overly strict in enforcing no-reuse when the Cipher was > in DECRYPT_MODE. For decryption, this should be allowed and be consistent > wit

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-19 Thread Martin Balao
On Wed, 17 May 2023 03:11:54 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v4]

2023-05-19 Thread Martin Balao
> We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goals and guidelines of > [JDK-8301553](https://bugs.open

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-19 Thread Martin Balao
On Wed, 17 May 2023 19:08:26 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Rebase fix after JDK-8306033. Replace called functions with their new >> names. >> - 8

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-19 Thread Martin Balao
On Fri, 19 May 2023 02:19:00 GMT, Martin Balao wrote: >> Good > > I've just noticed that in this case in particular we can clean it up here but > we need to save a copy in P11PBEKey because if the key has to be transferred > to a different P11 token, we need to re-derive from the password, salt

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-19 Thread Martin Balao
On Thu, 18 May 2023 20:07:37 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java >> line 345: >> >>> 343: throw new InvalidKeyException("Encoded format must be >>> RAW"); >>> 344: } >>> 345: byte

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
On Fri, 19 May 2023 19:58:10 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Ferenc: comments 2 and 4 >> - oops >> - Sean's comments >> - added @run > > test/jdk/sun/security/tools/jarsigner/V

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
On Fri, 19 May 2023 20:51:31 GMT, Weijun Wang wrote: >> test/jdk/sun/security/provider/lms/TestLMS.java line 30: >> >>> 28: * @summary tests for HSS/LMS provider >>> 29: * @modules java.base/sun.security.util >>> 30: * @run testng/othervm TestLMS >> >> Why is the test run with `testng`, can

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Weijun Wang
On Fri, 19 May 2023 20:08:08 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Ferenc: comments 2 and 4 >> - oops >> - Sean's comments >> - added @run > > test/jdk/sun/security/provider/lms/Test

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v6]

2023-05-19 Thread Weijun Wang
On Fri, 19 May 2023 12:19:56 GMT, Christoph Langer wrote: >> With this PR we try to be better in loading certificates from the MacOS >> Keychain into a JDK Trust store. >> >> The current implementation after JDK-8278449 would only load/trust >> certificates from an identity (with private key a

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v15]

2023-05-19 Thread Bradford Wetmore
On Fri, 19 May 2023 17:49:07 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - fix bug id in test header > - reworked example in

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Sean Mullan
On Fri, 19 May 2023 16:59:58 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with four additional > commits since the last revision: > > - Ferenc: comments 2 and 4 > - oops > - Sean's comments > - added @run

Re: RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2]

2023-05-19 Thread Jamil Nimeh
On Tue, 9 May 2023 15:56:02 GMT, Jamil Nimeh wrote: >> Yes, I noticed that too. I wasn't sure if we needed to make a change there. >> I opted to leave well-enough alone since nobody was asking for it and it's >> one less property to keep track of. All of these property sets end up with >> a

Re: RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3]

2023-05-19 Thread Jamil Nimeh
> This set of enhancements extends the allowed syntax for the > `com.sun.security.ocsp.timeout`, `com.sun.security.crl.timeout` and > `com.sun.security.crl.readtimeout` System properties. These properties > retain their current behavior where a purely numeric value is interpreted in > seconds,

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v17]

2023-05-19 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: rename class and remove bug id from test header - Changes: - all: https://git.openjdk.org/jdk/pull/134

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v16]

2023-05-19 Thread Sean Mullan
On Fri, 19 May 2023 19:38:09 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > removing block that isn't reached test/jdk/sun/secu

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v16]

2023-05-19 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: removing block that isn't reached - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - n

Integrated: 8305972: Update XML Security for Java to 3.0.2

2023-05-19 Thread Weijun Wang
On Fri, 5 May 2023 17:57:34 GMT, Weijun Wang wrote: > Update XML Security for Java to 3.0.2. Some change to tests: > > 1. A new `HereFunction.java` to test the new security property > "jdk.xml.dsig.hereFunctionSupported". > 2. EdDSA does not support `KeyValue`. Use X.509 certificate instead. T

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v15]

2023-05-19 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with two additional commits since the last revision: - fix bug id in test header - reworked example into a jtreg test - Changes: - all: https://git.openjd

Re: RFR: 8305972: Update XML Security for Java to 3.0.2 [v10]

2023-05-19 Thread Sean Mullan
On Thu, 18 May 2023 15:15:30 GMT, Weijun Wang wrote: >> Update XML Security for Java to 3.0.2. Some change to tests: >> >> 1. A new `HereFunction.java` to test the new security property >> "jdk.xml.dsig.hereFunctionSupported". >> 2. EdDSA does not support `KeyValue`. Use X.509 certificate inste

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with four additional commits since the last revision: - Ferenc: comments 2 and 4 - oops - Sean's comments - added @run - Changes: - all: https://git.openjdk.org/jdk/pull/13940

Re: RFR: 8301381: Verify DTLS 1.0 cannot be negotiated

2023-05-19 Thread Xue-Lei Andrew Fan
On Fri, 19 May 2023 12:03:54 GMT, Matthew Donovan wrote: > This PR implements a test to verify that a DTLS server running "out of the > box" (i.e., DTLSv1.0 disabled in java.security) will not handshake with a > client requesting DTLSv1.0. The test also implements the opposite: a client > won'

RFR: 8301381: Verify DTLS 1.0 cannot be negotiated

2023-05-19 Thread Matthew Donovan
This PR implements a test to verify that a DTLS server running "out of the box" (i.e., DTLSv1.0 disabled in java.security) will not handshake with a client requesting DTLSv1.0. The test also implements the opposite: a client won't handshake with a server that uses DTLSv1.0. - Commi

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v6]

2023-05-19 Thread Christoph Langer
> With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key available) and certificates > that have explicit trust set in the

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v5]

2023-05-19 Thread Christoph Langer
> With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key available) and certificates > that have explicit trust set in the

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v4]

2023-05-19 Thread Christoph Langer
> With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key available) and certificates > that have explicit trust set in the

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-19 Thread Michael McMahon
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote: >> Updated instances of `toLowerCase` and `toUpperCase` in several net and io >> files to specify `Locale.ROOT` to ensure that case conversion issues don't >> occur, >> >> I didn't add any new tests but ran tier 1-3 with no issues > > Dar

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-19 Thread Michael McMahon
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote: >> Updated instances of `toLowerCase` and `toUpperCase` in several net and io >> files to specify `Locale.ROOT` to ensure that case conversion issues don't >> occur, >> >> I didn't add any new tests but ran tier 1-3 with no issues > > Dar

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v3]

2023-05-19 Thread Christoph Langer
On Thu, 18 May 2023 00:00:58 GMT, Weijun Wang wrote: > Before your new change, such a certificate is not trusted, because > `SecTrustSettingsCopyTrustSettings` returns `errSecItemNotFound` so > `jm_createTrustedCertEntry` is not called at all. > > I am not sure if such a certificate is meant t

Re: RFR: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session [v2]

2023-05-19 Thread Daniel JeliƄski
On Wed, 26 Apr 2023 11:51:23 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8301686? >> >> The internal implementation of SSLContext caches SSLSession(s). These >> sessions are for a partic