On Fri, 19 May 2023 19:38:09 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > removing block that isn't reached test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 28: > 26: * @bug 8164879 > 27: * @library /test/lib > 28: * @summary test for proper exception handling Suggest adding more details here, ex: "Check that an improperly encoded CA distinguished name causes a handshake failure" test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 45: > 43: > 44: > 45: public class Test8294985 { I would avoid putting the bug number in the test name and use something more descriptive, like InvalidEncodedCaName. test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 64: > 62: + "/../../../../javax/net/ssl/etc/keystore"; > 63: > 64: private static byte[] payload = Base64.getDecoder().decode( Can you add a comment as to what is in this payload? test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 91: > 89: } > 90: > 91: System.out.println("payload len:" + payload.length); Is this println necessary? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199282222 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199283420 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199283669 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199284615
