On Fri, 4 Jun 2021 06:51:35 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and mak
On Wed, 8 Mar 2023 19:10:11 GMT, Andrey Turbanov wrote:
> java.util.Enumeration is a legacy interface from java 1.0.
> There is couple of places with cycles which use it to iterate over
> collections. We can replace this manual cycle with enchanced-for, which is
> shorter and easier to read.
`
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
My 2 ce
On Tue, 7 Mar 2023 21:19:37 GMT, Rajan Halade wrote:
> This fix removes the check for 90 days expiry. But the test will continue to
> fail if the expired certificate is included in `cacerts` but no exception is
> granted.
>
> Fix also includes minor code cleanup.
This pull request has now bee
On Wed, 8 Mar 2023 21:03:59 GMT, Rajan Halade wrote:
>> This fix removes the check for 90 days expiry. But the test will continue to
>> fail if the expired certificate is included in `cacerts` but no exception is
>> granted.
>>
>> Fix also includes minor code cleanup.
>
> Rajan Halade has upda
> This fix removes the check for 90 days expiry. But the test will continue to
> fail if the expired certificate is included in `cacerts` but no exception is
> granted.
>
> Fix also includes minor code cleanup.
Rajan Halade has updated the pull request incrementally with one additional
commit
On Tue, 7 Mar 2023 21:19:37 GMT, Rajan Halade wrote:
> This fix removes the check for 90 days expiry. But the test will continue to
> fail if the expired certificate is included in `cacerts` but no exception is
> granted.
>
> Fix also includes minor code cleanup.
test/jdk/sun/security/lib/cac
On Wed, 8 Mar 2023 19:10:11 GMT, Andrey Turbanov wrote:
> java.util.Enumeration is a legacy interface from java 1.0.
> There is couple of places with cycles which use it to iterate over
> collections. We can replace this manual cycle with enchanced-for, which is
> shorter and easier to read.
I
On 3/8/2023 2:19 PM, Andrey Turbanov wrote:
java.util.Enumeration is a legacy interface from java 1.0.
There is couple of places with cycles which use it to iterate over collections.
We can replace this manual cycle with enchanced-for, which is shorter and
easier to read.
-
Commit
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
Maybe i
java.util.Enumeration is a legacy interface from java 1.0.
There is couple of places with cycles which use it to iterate over collections.
We can replace this manual cycle with enchanced-for, which is shorter and
easier to read.
-
Commit messages:
- [PATCH] Use enhanced-for cycle i
On Tue, 7 Mar 2023 21:19:37 GMT, Rajan Halade wrote:
> This fix removes the check for 90 days expiry. But the test will continue to
> fail if the expired certificate is included in `cacerts` but no exception is
> granted.
>
> Fix also includes minor code cleanup.
Marked as reviewed by xuelei
On Tue, 7 Mar 2023 21:19:37 GMT, Rajan Halade wrote:
> This fix removes the check for 90 days expiry. But the test will continue to
> fail if the expired certificate is included in `cacerts` but no exception is
> granted.
>
> Fix also includes minor code cleanup.
>
The fix removes the early
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
ah, you
On Wed, 8 Mar 2023 15:15:52 GMT, Daniel Jeliński wrote:
>> This patch fixes a possible native memory leak in case of a custom native
>> GSS provider.
>> The actual leak was reported in production.
>>
>> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
>> are passed
>
On Wed, 8 Mar 2023 14:46:55 GMT, Daniel Jeliński wrote:
> Hi @TheShermanTanker What complier are you using? What command line?
>
> `security.cpp` compiles just fine with `-permissive-` here, both debug and
> release. I'm using this compiler:
>
> ```
> >cl.exe
> Microsoft (R) C/C++ Optimizing C
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
I'm not
On Wed, 8 Mar 2023 14:06:13 GMT, Julian Waters wrote:
>> security.cpp contains a few invalid implicit conversions between pointer
>> types that will not fly when the permissive- compiler option is active.
>> Given that permissive- will become the Visual C++ compiler's default mode of
>> operat
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrot
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrote:
> security.cpp contains a few invalid implicit conversions between pointer
> types that will not fly when the permissive- compiler option is active. Given
> that permissive- will become the Visual C++ compiler's default mode of
> operation
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote:
> This patch fixes a possible native memory leak in case of a custom native GSS
> provider.
> The actual leak was reported in production.
>
> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests
> are passed
@wangwe
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrote:
> security.cpp contains a few invalid implicit conversions between pointer
> types that will not fly when the permissive- compiler option is active. Given
> that permissive- will become the Visual C++ compiler's default mode of
> operation
This patch fixes a possible native memory leak in case of a custom native GSS
provider.
The actual leak was reported in production.
sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests are
passed
-
Commit messages:
- 8303809: Dispose context in SPNEGO Negoti
> Similar to what had been done in
> [JDK-8303354](https://bugs.openjdk.org/browse/JDK-8303354) , we miss
> CFRelease on the variable identitySearch in early CHECK_NULL returns
> potentially done in the function addIdentitiesToKeystore.
Matthias Baesken has updated the pull request incrementall
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrote:
> security.cpp contains a few invalid implicit conversions between pointer
> types that will not fly when the permissive- compiler option is active. Given
> that permissive- will become the Visual C++ compiler's default mode of
> operation
25 matches
Mail list logo
