Request - Preparation for removal of SecurityManager

2022-10-24 Thread Peter Firmstone
Would the OpenJDK team consider the following? Where SecurityManager is invoked directly now, such as:     @SuppressWarnings("removal")     SecurityManager sm = System.getSecurityManager();     if (sm != null)     sm.checkPermission(new RuntimePermission("setFactory")); Can

Re: Command line flag to disable finalizers.

2022-10-24 Thread Peter Firmstone
Hi Sean, I only just read this email, thanks, it allows us to start investigating a new authorization layer. Regards, Peter. On 21/04/2022 1:01 am, Sean Mullan wrote: On 4/15/22 10:46 PM, Peter Firmstone wrote: To securely instrument access controls onto public Java API, we need to have t

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Chris Plummer
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-24 Thread Sandhya Viswanathan
On Mon, 24 Oct 2022 22:09:29 GMT, vpaprotsk wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test to co

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-24 Thread vpaprotsk
> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare intrinsic and > java. > - Would like to add an `I

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v3]

2022-10-24 Thread vpaprotsk
On Mon, 24 Oct 2022 20:31:31 GMT, Sandhya Viswanathan wrote: >> vpaprotsk has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v4]

2022-10-24 Thread vpaprotsk
On Tue, 18 Oct 2022 23:03:55 GMT, Sandhya Viswanathan wrote: >> vpaprotsk has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains eight commits: >> >> - assembler checks and test case fixes >> - Merge remote-tracking branch 'origin/mas

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v4]

2022-10-24 Thread vpaprotsk
> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare intrinsic and > java. > - Would like to add an `I

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v4]

2022-10-24 Thread vpaprotsk
On Tue, 18 Oct 2022 06:26:38 GMT, Jatin Bhateja wrote: >> vpaprotsk has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains eight commits: >> >> - assembler checks and test case fixes >> - Merge remote-tracking branch 'origin/master' in

Integrated: 8295716: Minimize disabled warnings in security libs

2022-10-24 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote: > After JDK-8294281, it is now possible to disable warnings for individual > files instead for whole libraries. I used this opportunity to go through all > disabled warnings in the security native libraries. > > Any warnings that were

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Magnus Ihse Bursie
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote: > I think it would be better to try and remove incidental trailing whitespace > first, before encoding any remaining whitespace. Hiding the trailing > whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping > the is

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v3]

2022-10-24 Thread Sandhya Viswanathan
On Fri, 21 Oct 2022 20:20:58 GMT, vpaprotsk wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test to co

Withdrawn: 8133816: Display extra SSLServerSocket info in debug mode

2022-10-24 Thread duke
On Wed, 3 Aug 2022 15:40:54 GMT, Weibing Xiao wrote: > Log the debugging info for server cipher suites when setting javax.net.debug > == ssl, handshake. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9731

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote: > Good idea! I wonder if this should be done as a unit test. go through all the > bundles and check leading/trailing whitespace. Right. Definitely not a job for `jcheck`, but it should be considered somewhere in the l10n process. ---

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Andy Goryachev
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote: > I think what we can do is check the original English properties values that > the engineers provided, and if there is no trailing spaces there, we can > safely remove trailing spaces in localized bundles. Good idea! I wonder if this should

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Andy Goryachev
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Remove check for .properties from jcheck" >> >>This reverts commit c91fdaa19dc06351598bd1c061

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Andy Goryachev
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote: > For the files which have trailing "whitespace" (now as unicode sequences), I > will file follow-up bugs on the respective components to verify if this is > indeed correct, or a bug that should be fixed. probably not needed - if nobo

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Jonathan Gibbons
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Magnus Ihse Bursie
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Andy Goryachev
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-24 Thread Magnus Ihse Bursie
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove check for .properties from jcheck >> - Restore trailing whitespace for property values > > 368 files

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Magnus Ihse Bursie
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-24 Thread Andy Goryachev
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v3]

2022-10-24 Thread Magnus Ihse Bursie
> Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the coverage of the > whitespace checks (in the old mercurial ve

Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-24 Thread Mark Powers
On Sat, 22 Oct 2022 15:37:38 GMT, Florent Guillaume wrote: >> https://bugs.openjdk.org/browse/JDK-8293093 > > Given the repeated code wouldn't you want to create a small helper method > like `getIDNullSafe`? @efge Good suggestion. And having `NullSafe` in the name answers an important question

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v3]

2022-10-24 Thread Sandhya Viswanathan
On Fri, 21 Oct 2022 20:20:58 GMT, vpaprotsk wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test to co

Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-24 Thread Sean Mullan
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 You should add a `noreg` label (ex: `noreg-trivial` or `noreg-other`) to the bug if you don't plan on writing a regression test. - PR: https://git.openjdk.org/jdk/pull/10823

Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-24 Thread Anthony Scarpino
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 Looking at the usage of getID(), it seems like debug msgs and exceptions are where the null maybe a problem. mapLabel() checks for null. It maybe best to change getID(bytes[]) to return new Str

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v3]

2022-10-24 Thread Tobias Hartmann
On Fri, 21 Oct 2022 20:20:58 GMT, vpaprotsk wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test to co