On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase the coverage of the
>> whitespace checks (in the old mercurial version, this was more or less
>> impossible).
>>
>> The only manual change is to `.jcheck/conf`. All other changes were made by
>> running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[
>> \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Revert "Remove check for .properties from jcheck"
>
> This reverts commit c91fdaa19dc06351598bd1c0614e1af3bfa08ae2.
> - Change trailing space and tab in values to unicode encoding
Started looking at whether certain trailing spaces can be (and/or should be)
removed, but it quickly became apparent that we should just keep these
properties as is (with the unicode escapes), rather than risk regression.
src/demo/share/jfc/SwingSet2/resources/swingset_ja.properties line 187:
> 185: ### Button Demo ###
> 186:
> 187:
> ButtonDemo.accessible_description=ButtonDemo\u3067\u306F\u3001JButton\u3001JRadioButton\u3001JToggleButton\u304A\u3088\u3073JCheckBox\u306E\u4F7F\u7528\u4F8B\u3092\u7D39\u4ECB\u3057\u307E\u3059\u0020
trailing whitespace looks unnecessary (accessible description?)
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
line 67:
> 65: FileChooser.renameErrorTitle.textAndMnemonic=Fehler beim Umbenennen von
> Datei oder Ordner
> 66: FileChooser.renameError.textAndMnemonic={0} kann nicht umbenannt werden
> 67: FileChooser.renameErrorFileExists.textAndMnemonic={0} kann nicht
> umbenannt werden: Es ist bereits eine Datei mit dem angegebenen Namen
> vorhanden. Geben Sie einen anderen Dateinamen an.\u0020
prob. unnecessary
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
line 67:
> 65: FileChooser.renameErrorTitle.textAndMnemonic=Error al cambiar el nombre
> del archivo o carpeta
> 66: FileChooser.renameError.textAndMnemonic=No se puede cambiar el nombre de
> {0}
> 67: FileChooser.renameErrorFileExists.textAndMnemonic=No se puede cambiar el
> nombre de {0}: ya existe un archivo con el nombre especificado. Especifique
> otro nombre de archivo.\u0020
prob. unnecessary
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
line 67:
> 65: FileChooser.renameErrorTitle.textAndMnemonic=Erreur lors du changement de
> nom du fichier ou du dossier
> 66: FileChooser.renameError.textAndMnemonic=Impossible de renommer {0}
> 67: FileChooser.renameErrorFileExists.textAndMnemonic=Impossible de renommer
> {0} : il existe d\u00E9j\u00E0 un fichier portant le nom indiqu\u00E9.
> Indiquez-en un autre.\u0020
prob. unnecessary
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
line 67:
> 65: FileChooser.renameErrorTitle.textAndMnemonic=Errore durante la
> ridenominazione del file o della cartella
> 66: FileChooser.renameError.textAndMnemonic=Impossibile rinominare {0}
> 67: FileChooser.renameErrorFileExists.textAndMnemonic=Impossibile rinominare
> {0}: esiste gi\u00E0 un file con il nome specificato. Specificare un altro
> nome.\u0020
prob. unnecessary
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
line 67:
> 65:
> FileChooser.renameErrorTitle.textAndMnemonic=\u30D5\u30A1\u30A4\u30EB\u307E\u305F\u306F\u30D5\u30A9\u30EB\u30C0\u306E\u540D\u524D\u5909\u66F4\u30A8\u30E9\u30FC
> 66:
> FileChooser.renameError.textAndMnemonic={0}\u306E\u540D\u524D\u3092\u5909\u66F4\u3067\u304D\u307E\u305B\u3093
> 67:
> FileChooser.renameErrorFileExists.textAndMnemonic={0}\u306E\u540D\u524D\u3092\u5909\u66F4\u3067\u304D\u307E\u305B\u3093:
>
> \u6307\u5B9A\u3057\u305F\u540D\u524D\u306E\u30D5\u30A1\u30A4\u30EB\u306F\u3059\u3067\u306B\u5B58\u5728\u3057\u307E\u3059\u3002\u5225\u306E\u30D5\u30A1\u30A4\u30EB\u540D\u3092\u6307\u5B9A\u3057\u3066\u304F\u3060\u3055\u3044\u3002\u0020
prob. unnecessary
src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
line 67:
> 65: FileChooser.renameErrorTitle.textAndMnemonic=Ett fel intr\u00E4ffade vid
> f\u00F6rs\u00F6k att \u00E4ndra namn p\u00E5 fil eller mapp
> 66: FileChooser.renameError.textAndMnemonic=Kan inte namn\u00E4ndra {0}
> 67: FileChooser.renameErrorFileExists.textAndMnemonic=Kan inte namn\u00E4ndra
> {0}: En fil med angivet namn finns redan. Ange ett annat filnamn.\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties
line 44:
> 42: cachedrowsetimpl.floatfail = getFloat failed on value ( {0} ) in column
> {1}
> 43: cachedrowsetimpl.doublefail = getDouble failed on value ( {0} ) in column
> {1}
> 44: cachedrowsetimpl.dtypemismt = Data Type Mismatch\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties
line 73:
> 71: cachedrowsetimpl.numrows = Number of rows is less than zero or less than
> fetch size
> 72: cachedrowsetimpl.startpos = Start position cannot be negative
> 73: cachedrowsetimpl.nextpage = Populate data before calling\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties
line 87:
> 85:
> 86: #FilteredRowSetImpl exceptions
> 87: filteredrowsetimpl.relative = relative : Invalid cursor operation\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties
line 128:
> 126: crswriter.params1 = Value of params1 : {0}\u0020
> 127: crswriter.params2 = Value of params2 : {0}\u0020
> 128: crswriter.conflictsno = conflicts while synchronizing\u0020
this is tricky. if this value is a part of a sentence (i.e. something like "5
conflicts..."), the localization is likely to be wrong. it's hard to tell
without looking further into the code.
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties
line 134:
> 132:
> 133: #SyncResolverImpl exceptions
> 134: syncrsimpl.indexval = Index value out of range\u0020\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties
line 44:
> 42: cachedrowsetimpl.floatfail = getFloat bei Wert ( {0} ) in Spalte {1}
> nicht erfolgreich
> 43: cachedrowsetimpl.doublefail = getDouble bei Wert ( {0} ) in Spalte {1}
> nicht erfolgreich
> 44: cachedrowsetimpl.dtypemismt = Keine Datentyp\u00FCbereinstimmung\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties
line 73:
> 71: cachedrowsetimpl.numrows = Zeilenanzahl ist kleiner als null oder kleiner
> als Abrufgr\u00F6\u00DFe
> 72: cachedrowsetimpl.startpos = Startposition darf keinen Negativwert
> aufweisen
> 73: cachedrowsetimpl.nextpage = Daten m\u00FCssen vor dem Aufruf
> ausgef\u00FCllt werden\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties
line 87:
> 85:
> 86: #FilteredRowSetImpl exceptions
> 87: filteredrowsetimpl.relative = relative: Ung\u00FCltiger
> Cursorvorgang\u0020
prob. unnecessary
src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties
line 134:
> 132:
> 133: #SyncResolverImpl exceptions
> 134: syncrsimpl.indexval = Indexwert liegt au\u00DFerhalb des
> Bereichs\u0020\u0020
prob. unnecessary
-------------
Marked as reviewed by angorya (no project role).
PR: https://git.openjdk.org/jdk/pull/10792
