Re: [sage-devel] Re: tabs in the Sage library

2010-04-17 Thread Nicolas M. Thiery
On Sat, Apr 17, 2010 at 03:52:36PM -0700, John H Palmieri wrote: > I think this is a good idea, but might be a bit harder to implement. > That is, it's easy to print out a warning if there is a tab in a file > when the file is doctested, but if you doctest the whole Sage library, > printing out war

[sage-devel] Re: tabs in the Sage library

2010-04-17 Thread John H Palmieri
On Apr 17, 2:27 pm, "Nicolas M. Thiery" wrote: > But please please, let's do that smoothly without conflicting with all > the current developments. To this end, I vote for sage -t to report > tabs as warnings (not failures) for the moment. I think this is a good idea, but might be a bit harder t

Re: [sage-devel] Re: tabs in the Sage library

2010-04-17 Thread Nicolas M. Thiery
On Fri, Apr 16, 2010 at 12:53:04AM +0200, Florent hivert wrote: > > I think we should do this once, after a tool is in place to make sure these > > things don't get in anymore. > > > > A big +1 to sage -t failing on files that have tabs, lack newlines, or > > whatever else the style guide enforce

Re: [sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Florent Hivert
Hi there, > I think we should do this once, after a tool is in place to make sure these > things don't get in anymore. > > A big +1 to sage -t failing on files that have tabs, lack newlines, or > whatever else the style guide enforces. I've also thought it would be > useful to have a trac pl

[sage-devel] Re: tabs in the Sage library

2010-04-15 Thread John H Palmieri
On Apr 15, 2:48 pm, "Nathan O'Treally" wrote: > I'm not happy with "brute-force" converting *any* tab to space(s), and > it would be better to have a tool that (conditionally) does this > rather than supplying patches to lots of files converted by Emacs. The > same tool could be used just to check

Re: [sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Robert Bradshaw
On Apr 15, 2010, at 2:48 PM, Nathan O'Treally wrote: I'm not happy with "brute-force" converting *any* tab to space(s), and it would be better to have a tool that (conditionally) does this rather than supplying patches to lots of files converted by Emacs. The same tool could be used just to chec

[sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Nathan O'Treally
I'm not happy with "brute-force" converting *any* tab to space(s), and it would be better to have a tool that (conditionally) does this rather than supplying patches to lots of files converted by Emacs. The same tool could be used just to check for "illegal" tabs. As I understand this, these are *t

[sage-devel] Re: tabs in the Sage library

2010-04-12 Thread John H Palmieri
On Apr 12, 8:36 pm, William Stein wrote: > On Mon, Apr 12, 2010 at 8:26 PM, John H Palmieri > wrote: > > > Yes.  Another option: should "sage -t" fail on any file with tabs? > > Then the responsibility would fall more to the patch authors than to > > the release managers. > > +1 -- I greatly pr

Re: [sage-devel] Re: tabs in the Sage library

2010-04-12 Thread William Stein
On Mon, Apr 12, 2010 at 8:26 PM, John H Palmieri wrote: > On Apr 12, 7:54 pm, Dan Drake wrote: >> Hello, >> >> A while back, there was a massive patch that removed all the tabs from >> the Sage library. Unfortunately, they have been creeping back in, and >> there are now quite a few files with ta

[sage-devel] Re: tabs in the Sage library

2010-04-12 Thread John H Palmieri
On Apr 12, 7:54 pm, Dan Drake wrote: > Hello, > > A while back, there was a massive patch that removed all the tabs from > the Sage library. Unfortunately, they have been creeping back in, and > there are now quite a few files with tabs: try doing > >       grep --perl-regexp '\t' --files-with-mat