On Fri, Apr 16, 2010 at 12:53:04AM +0200, Florent hivert wrote:
> > I think we should do this once, after a tool is in place to make sure these
> > things don't get in anymore.
> >
> > A big +1 to sage -t failing on files that have tabs, lack newlines, or
> > whatever else the style guide enforces. I've also thought it would be
> > useful to have a trac plugin that points out such things (and it could
> > report coverage changes as well).
>
> I'm also +1 on these with the following reserve:
>
> Whatever solution is taken, I'm quite concerned with the forthcoming nightmare
> of rebasing the combinat queue while trying to keep it compatible with the
> former version (currently the queue still apply on sage-4.3.1). At the very
> least, the patch should be the first entering a new sage release. So that we
> can apply the script on the few former version to get compatibility patch and
> have a at-most-as-possible-common tab-free base for the queue.
A big +1 as well for getting rid of tabs, and on having sage -t report
them!
But please please, let's do that smoothly without conflicting with all
the current developments. To this end, I vote for sage -t to report
tabs as warnings (not failures) for the moment. This should be enough
of an incentive for the developers working in the various code areas
to fix those as a side effect of their own development. In a couple
releases, we can then switch to errors. Those remaining tabs, if any,
will then be in stable areas and can be fixed then without risks of
conflicts.
By the way, it would be nice to have sage -t also report as warnings:
- non ascii characters (unless the encoding is specified)
- trailing white spaces
Speaking of those: they sure are anesthetic and I remove them when I
spot some around lines I am anyway changing. But apart from
exceptional situations like Minh's, they seem quite harmless. So
fixing those should not cause any risk of conflict. I think a warning
would enough of an incent.
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
