On Mon, Apr 12, 2010 at 8:26 PM, John H Palmieri <jhpalmier...@gmail.com> wrote:
> On Apr 12, 7:54 pm, Dan Drake <dr...@kaist.edu> wrote:
>> Hello,
>>
>> A while back, there was a massive patch that removed all the tabs from
>> the Sage library. Unfortunately, they have been creeping back in, and
>> there are now quite a few files with tabs: try doing
>>
>> grep --perl-regexp '\t' --files-with-matches -r sage/*
>
> or from sage: search_src("\t")
>
> This is annoying; it was a pain to get rid of the tabs last time. If
> I remember, having tabs in a file can cause problems with Sphinx,
> maybe with displaying help in the notebook.
>
>> Coordinating another big tab removal patch would be difficult, but I
>
> I put together a patch in about 20 minutes, using search_src("\t") and
> the emacs "untabify" function. If our next release is 4.4, then 4.4.1
> could be purely an untabify release...
>
>> think that we could at least change the "sage -merge" script so that it
>> rejects any patch that introduces tabs. (Unless, say, some kind of
>> --no-really-the-tabs-are-okay command line option is specified.) Does
>> this seem like a good idea?
>
> Yes. Another option: should "sage -t" fail on any file with tabs?
> Then the responsibility would fall more to the patch authors than to
> the release managers.
+1 -- I greatly prefer that option. In particular, it means that a
release manager does not have to use "sage -merge" if they don't want
to. Changing sage -t is much better.
-- William
--
William Stein
Professor of Mathematics
University of Washington
http://wstein.org
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
To unsubscribe, reply using "remove me" as the subject.
